Conversation
Since we are manually uploading the build artifacts now in the release workflow.
Wait until electron v8 to bump to node v24
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build/release pipeline and Electron Forge configuration to support the project’s current release process, including standardized Node tooling and revised artifact publishing.
Changes:
- Reworked
release.ymlto build distributables viapnpm make, upload them as workflow artifacts, then attach them to the GitHub Release viagh. - Simplified
forge.config.tsaround build identifiers/product naming and adjusted Fuse behavior for universal macOS builds. - Pinned Node via
.node-version, updated docs/changelog, and adjusted dependencies/lockfile accordingly.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates deployment documentation to reflect the current release process. |
| pnpm-lock.yaml | Removes Forge GitHub publisher packages; adds/locks updated dependencies. |
| package.json | Removes publish script and Forge GitHub publisher; bumps version; adds lodash. |
| forge.config.ts | Removes Forge GitHub publisher config; simplifies naming/build identifier; adjusts fuses behavior for universal macOS builds. |
| CHANGELOG.md | Adds entries for recent RC iterations related to build/release fixes. |
| .vscode/settings.json | Adds additional spellchecker dictionary entries. |
| .node-version | Pins Node version used by CI. |
| .github/workflows/release.yml | Builds on release publish, uploads artifacts, and attaches them to the release. |
| .github/workflows/pull_request.yml | Uses .node-version for consistent Node versioning in PR checks. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
acneville
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a lot of trial and error to get the builds fixed. I think that some of this was left over from when this project was migrated to our official release action.