fix(harness): support asynchronous memory flush - #2833
Open
guslegend0510 wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoryConfig.asyncFlush(boolean)option forHarnessAgentMotivation
HarnessAgentcurrently waits for the per-call memory flush to complete before completing the response stream.When the memory model responds slowly, this can significantly delay the agent response. The deprecated
ReActAgent.longTermMemoryAsyncRecord(...)option does not apply toHarnessAgent.This change provides an equivalent opt-in asynchronous mode:
The default remains
false, preserving the existing completion and persistence semantics.Behavior
When
asyncFlushis enabled:Asynchronous flushes are fire-and-forget. In-flight flushes are not awaited during
HarnessAgent.close(), so applications that exit immediately may stop before persistence completes.Testing
Results:
Fixes #2821