Skip to content

fix(sandbox-e2b): preserve zero exit codes in envd streams #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikemikimike wants to merge 7 commits into
base: main
Choose a base branch
from
+15 −3
Open

fix(sandbox-e2b): preserve zero exit codes in envd streams #2804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0cab093
fix(sandbox-e2b): preserve zero exit codes
mikemikimike Aug 22, 2026
9ef4696
Merge upstream main into e2b exit code fix
mikemikimike Aug 23, 2026
21e2eca
Fix duplicate test declarations
mikemikimike Aug 23, 2026
39e3f7e
Repair merged E2B test setup
mikemikimike Aug 23, 2026
21ed634
test(sandbox-e2b): cover empty end events
mikemikimike Aug 24, 2026
6df1778
test(sandbox-e2b): remove ambiguous empty end assertion
mikemikimike Aug 25, 2026
0e91f16
fix(sandbox-e2b): treat empty end events as success
mikemikimike Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...-sandbox-e2b/src/main/java/io/agentscope/extensions/sandbox/e2b/E2bEnvdProcessClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,11 @@ private DynamicMessage parseJsonStartResponse(byte[] data) throws IOException {
DynamicMessage.Builder endBuilder = DynamicMessage.newBuilder(endDesc);
Descriptors.FieldDescriptor exitCodeField = endDesc.findFieldByName("exit_code");
JsonNode exitCodeNode = endNode.path("exitCode");
if (exitCodeNode.canConvertToInt()) {
boolean hasExitCode = exitCodeNode.canConvertToInt();
if (hasExitCode) {
endBuilder.setField(exitCodeField, exitCodeNode.intValue());
event.setField(processEventDesc.findFieldByName("end"), endBuilder.build());
}
event.setField(processEventDesc.findFieldByName("end"), endBuilder.build());
}

if (!event.getAllFields().isEmpty()) {
Expand Down
13 changes: 12 additions & 1 deletion ...dbox-e2b/src/test/java/io/agentscope/extensions/sandbox/e2b/E2bEnvdProcessClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ void jsonCodecReturnsEmptyOutputsWhenOnlyEndPresent() throws Exception {
}

@Test
void jsonCodecPreservesZeroExitCode() throws Exception {
void jsonCodecPreservesSuccessfulExitCode() throws Exception {
E2bEnvdProcessClient client = new E2bEnvdProcessClient(options(E2bCodec.JSON));
ByteArrayOutputStream stdout = new ByteArrayOutputStream();
ByteArrayOutputStream stderr = new ByteArrayOutputStream();
Expand All @@ -158,6 +158,17 @@ void jsonCodecPreservesZeroExitCode() throws Exception {
assertEquals(0, exit);
}

@Test
void jsonCodecTreatsEmptyEndEventAsSuccessfulExit() throws Exception {
E2bEnvdProcessClient client = new E2bEnvdProcessClient(options(E2bCodec.JSON));
ByteArrayOutputStream stdout = new ByteArrayOutputStream();
ByteArrayOutputStream stderr = new ByteArrayOutputStream();
int exit =
drainStartStream(client, connectFrame("{\"event\":{\"end\":{}}}"), stdout, stderr);

assertEquals(0, exit);
}

private static DynamicMessage dataResponse(
E2bEnvdProcessClient client, String stdout, String stderr) {
Descriptors.FileDescriptor fd = client.fileDescriptor();
Expand Down
Loading