fix(mysql): remove path-separator check from MysqlAgentStateStore session id validation #2022
Open
zhaojinyu wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "fix/\ue000MysqlAgentStateStor_bug"
Open
fix(mysql): remove path-separator check from MysqlAgentStateStore session id validation #2022zhaojinyu wants to merge 1 commit into
zhaojinyu wants to merge 1 commit into
Conversation
…ore session id validation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ore session id validation
2.0.0-SNAPSHOT
[The version of AgentScope-Java you are working on, e.g. 1.0.12, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Summary
MysqlAgentStateStore.validateSessionId() rejects any session id containing / or , which makes it incompatible with legitimate callers such as SessionSandboxStateStore. This
PR removes that check because it is a filesystem-oriented constraint that has no meaning for a relational store and violates the AgentStateStore interface contract that other
implementations (e.g. JsonFileAgentStateStore) already honor.
Problem
SessionSandboxStateStore.slotSessionId(SandboxIsolationKey) composes a session id from the isolation scope, e.g.:
Every one of these contains / as a namespace delimiter. When the underlying AgentStateStore is MysqlAgentStateStore, every load/save/delete call goes through
validateSessionId(String) at MysqlAgentStateStore.java:811, which throws:
IllegalArgumentException: AgentStateStore ID cannot contain path separators
Result: sandbox lifecycle state cannot be persisted or resumed at all when MySQL is used as the state backend, so distributed sandbox resume — the very feature the
class-level Javadoc of SessionSandboxStateStore advertises — is broken for MySQL users.
Root Cause
The rejected characters (/, ) are path separators, not database characters. The error message itself gives away that this check was copied from a filesystem-oriented store.
mvn spotless:applymvn test)