fix(mcp): expose streamable HTTP resumable transport options#2006
Open
guslegend0510 wants to merge 2 commits into
Open
fix(mcp): expose streamable HTTP resumable transport options#2006guslegend0510 wants to merge 2 commits into
guslegend0510 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
Do you think it reasonable if we disable SSE by default when streamable is enabled? Currently, user has to set Also, have you checked the latest MCP sdk release? I mean will it bring any behaviour changes if we upgrade to the latest version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes #2003.
When connecting to a Streamable HTTP MCP server that disables SSE and only accepts POST requests, tool calls can hang because AgentScope-Java does not expose the underlying MCP SDK transport options needed to disable resumable SSE-style startup behavior.
What Changed
resumableStreams(boolean)onMcpClientBuilderfor Streamable HTTP transportopenConnectionOnStartup(boolean)onMcpClientBuilderfor Streamable HTTP transportHttpClientStreamableHttpTransport.BuilderresumableStreamsandopenConnectionOnStartupsupport totools.jsonMCP server configMcpServerRegistrarExample
Java API:
Testing
mvn -pl "agentscope-core,agentscope-harness" spotless:apply
mvn -pl "agentscope-core,agentscope-harness" "-Dtest=McpClientBuilderTest,ToolsConfigLoaderTest" test