fix(tests): skip install.sh rc-dedup regression test on Windows - #945
Merged
ericleepi314 merged 1 commit intoSep 19, 2026
Merged
ericleepi314 merged 1 commit into
ericleepi314 merged 1 commit into
Conversation
tests/test_install_sh_rc_dedup.py extracts and runs update_shell_rc()'s real body from install.sh via bash/sed/grep -- it's a POSIX-shell test, not a claim that install.sh runs on native Windows. On windows-latest CI it fails all 5 cases with an unrelated "Could not determine home directory" error from spawning bash with a replaced (HOME/PATH-only) environment, not from any real regression in the fix. Skip it there, following the same sys.platform == "win32" pattern already used by other POSIX-only tests in this suite. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Test Results 5 files 1 018 suites 28m 48s ⏱️ For more details on these failures, see this check. Results for commit d07e583. |
Collaborator
|
agree. Windows tests are always failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_install_sh_rc_dedup.py(added in fix(install): stop update_shell_rc from duplicating its PATH block forever #943) extracts and runsupdate_shell_rc()'s real body frominstall.shviabash/sed/grep— it's a POSIX-shell test of a bash function, not a claim thatinstall.shruns on native Windows.windows-latestCI it fails all 5 cases, but not from any regression in the actual fix: the failure isRuntimeError: Could not determine home directory, coming from spawningbashwith a replaced (HOME/PATH-only) environment on that runner — an environment-setup issue unrelated toupdate_shell_rc()'s logic.sys.platform == "win32"pattern already used by other POSIX-only tests in this suite (e.g.test_tui_model_picker_stats_e2e.py,test_dangerous_skip_permissions.py).Test plan
pytest tests/test_install_sh_rc_dedup.py -v— all 5 tests still pass on macOS (skip only triggers onwin32)pytest.mark.skipif(sys.platform == "win32", ...)idiom is already used and CI-verified elsewhere in this repo🤖 Generated with Claude Code