fix(web): a column drag no longer re-renders the app or re-lays out an embedded document per pixel - #937
Merged
Conversation
…n embedded document per pixel Two things made a right-column drag heavy on a full page. The shell and the conversation root subscribed to the column's width itself, so every pixel of a drag re-rendered the whole app; they now subscribe to whether the column is open, which changes only when it opens or closes. And an HTML preview's frame (or a PDF) followed the column pixel by pixel, laying its document out again each time — a page of wide tables can take longer per pixel than a frame lasts. While a handle is held the frame keeps the width it had, and the release lays it out once, at the final width. The width preference is also persisted once the writes settle rather than on every frame. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018nGcaynrdG2uR3d2r1EczY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #936, for the resize cursor that lingered after a release. Two things made a right-column drag heavy on a full page:
Verification
ui-web:npm run typecheckclean;vitest run50 files, 631 tests passing, with tests for the published drag state, the open/closed store changing only on open and close, and the frame's width freezing and thawing.🤖 Generated with Claude Code
https://claude.ai/code/session_018nGcaynrdG2uR3d2r1EczY