fix(streaming): normalize timestamps across common units#179
Merged
krisztianfekete merged 1 commit intoJul 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
_normalize_tsfunction previously distinguished only betweennanosecond timestamps and timestamps that were assumed to already be
in seconds.
This caused microsecond timestamps to be treated as nanoseconds. For
example,
1770000000000000microseconds was converted to1770000.0seconds instead of
1770000000.0seconds.Millisecond timestamps had a similar problem because they were treated
as seconds without conversion.
Changes
_normalize_tsto infer contemporary Unix timestamp unitsby magnitude.
nanoseconds.
0.0fallback for missing or malformedtimestamp values.
intended for contemporary Unix timestamps.
None, and malformed input.Testing
I ran the following checks:
7 passed.97 passed.756 passed, 25 skipped, 3 failed.The three remaining failures are Windows symlink security tests that
require privileges to create symbolic links. The same three failures
were present before this change and are unrelated to timestamp
normalization.
Related issue
This PR addresses the timestamp normalization item in #175. It does
not close #175 because that issue contains several independent cleanup
tasks.
AI assistance
I used GPT 5.6Sol to help me understand the project architecture.