Skip to content

fix(ack-pay): reject unsafe integer amounts in valibot payment option schema #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazywriter1 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(ack-pay): reject unsafe integer amounts in valibot payment option schema #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/payment-option-safe-integer-amount.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@agentcommercekit/ack-pay": patch
---

Reject unsafe integer numbers on the payment option amount number arm so valibot matches zod (and Number.isSafeInteger), keeping the string arm for amounts larger than the safe integer range.
7 changes: 7 additions & 0 deletions packages/ack-pay/src/schemas/payment-option.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,11 @@ describe("paymentOptionSchema amount", () => {
expect(acceptsAmount(amount)).toEqual({ valibot: false, zod: false })
},
)

it.each([Number.MAX_SAFE_INTEGER + 1, 1e21])(
"rejects an unsafe integer number amount %s",
(amount) => {
expect(acceptsAmount(amount)).toEqual({ valibot: false, zod: false })
},
)
})
3 changes: 2 additions & 1 deletion packages/ack-pay/src/schemas/valibot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ const timestampSchema = v.pipe(
export const paymentOptionSchema = v.object({
id: v.string(),
amount: v.union([
v.pipe(v.number(), v.integer(), v.gtValue(0)),
// Unsafe integers are not exact; use the string arm for large amounts.
v.pipe(v.number(), v.safeInteger(), v.gtValue(0)),
positiveIntegerString,
]),
decimals: v.pipe(v.number(), v.integer(), v.toMinValue(0)),
Expand Down