Skip to content

fix(issue #27): added an optional limit parameter#28

Merged
PsiACE merged 2 commits into
mainfrom
support-limit
Nov 14, 2025
Merged

fix(issue #27): added an optional limit parameter#28
PsiACE merged 2 commits into
mainfrom
support-limit

Conversation

@PsiACE

@PsiACE PsiACE commented Nov 13, 2025

Copy link
Copy Markdown
Member

Close: #27

…sport and stdio_streams

Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
@PsiACE

PsiACE commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

cc @OhadRubin, could you please review this?

@OhadRubin OhadRubin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do have some nitpicks but this looks fine.

Might set a more reasonable default?

@PsiACE

PsiACE commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

Might set a more reasonable default?

Good idea, but it seems that in UI displays, most modern tools collapse content (and don't allow expansion) to avoid overwhelming users with large amounts of information. I'd like to consult @stdrc , who built kimi-cli, as it's one of the primary use cases at present.

@PsiACE PsiACE merged commit 51054b0 into main Nov 14, 2025
7 checks passed
@PsiACE PsiACE deleted the support-limit branch November 14, 2025 13:29
@xxchan

xxchan commented Dec 8, 2025

Copy link
Copy Markdown

Might set a more reasonable default?

Good idea, but it seems that in UI displays, most modern tools collapse content (and don't allow expansion) to avoid overwhelming users with large amounts of information. I'd like to consult @stdrc , who built kimi-cli, as it's one of the primary use cases at present.

One concrete reasonable use case: base64 encoded image...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACP Buffer Limit Issue

3 participants