Do not replay rolled-back turns from history fallback - #356
Open
Skywt2003 wants to merge 1 commit into
Open
Conversation
Skywt2003
marked this pull request as ready for review
August 2, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thread_rolled_backbefore replaying response-item fallback historytask_startedas the turn boundary, withuser_messagefallback for legacy rolloutsFixes #355.
Root cause
The app-server thread contains only the active conversation, but the response-item fallback reads the append-only rollout and previously ignored
thread_rolled_back. Merging both histories could therefore restore an obsolete prompt and answer after a message edit.Validation
npm run typechecknpm test— 342 passed, 28 skippednpm run build