Skip to content

update valkey to use hostname #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Elder (BenTheElder) merged 1 commit into from
Jun 17, 2026
+18 −7
Merged

update valkey to use hostname #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions manifests/ate-install/valkey.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,20 @@ spec:
containers:
- name: valkey
image: valkey/valkey:8.0

@BenTheElder Benjamin Elder (BenTheElder) Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I thought we had digest pinned this ... TODO (not new to this PR, just noticing, have a couple missing ...)

command: ["valkey-server", "/etc/valkey/valkey.conf"]
command:
- /bin/sh
- -c
- |
set -e
POD_DNS="${HOSTNAME}.valkey-cluster-service.ate-system.svc"
cp /etc/valkey/valkey.conf /tmp/valkey.conf
{
echo "cluster-announce-hostname ${POD_DNS}"
echo "cluster-announce-tls-port 6379"
echo "cluster-announce-bus-port 16379"
echo "cluster-preferred-endpoint-type hostname"
} >> /tmp/valkey.conf
exec valkey-server /tmp/valkey.conf
ports:
- name: valkey
containerPort: 6379
Expand Down Expand Up @@ -166,11 +179,10 @@ spec:
done
done

echo "All pods resolved. Getting IPs..."
POD_IPS=""
echo "All pods resolved. Building stable node list..."
VALKEY_NODES=""
for i in 0 1 2 3 4 5; do
ip=$(getent hosts valkey-cluster-${i}.valkey-cluster-service.ate-system.svc | awk '{print $1}')
POD_IPS="${POD_IPS} ${ip}:6379"
VALKEY_NODES="${VALKEY_NODES} valkey-cluster-${i}.valkey-cluster-service.ate-system.svc:6379"
done

echo "Checking if Valkey cluster is already initialized..."
Expand All @@ -187,7 +199,7 @@ spec:
--cacert /etc/valkey-ca/ca.crt \
--cert /run/servicedns.podcert.ate.dev/credential-bundle.pem \
--key /run/servicedns.podcert.ate.dev/credential-bundle.pem \
--cluster create ${POD_IPS} \
--cluster create ${VALKEY_NODES} \
--cluster-replicas 1 \
--cluster-yes
echo "Cluster initialization complete!"
Expand All @@ -210,4 +222,3 @@ spec:
items:
- key: ca.crt
path: ca.crt

Loading