chore(dead-code): remove 13 confirmed-dead items across codebase (fixes #690)#702
Merged
Conversation
#690) Delete the entire orphaned agentfox/fix/ module (10 files, ~2200 lines) whose CLI entry point was already removed. Remove individual dead items: AssessmentManager stub, _BARE_FILE_RE regex, format_verdict_parts/ sort_verdicts, converge_multi_instance_skeptic, merge_fast_forward, PullRequestResult/create_pull_request, write-only self._instances, shallow_merge, execute_batch, VSS extension load, Campaign re-export, and broken afaudit.nightshift_summary import. Delete or update all associated tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 13 grep-verified dead code items across engine, knowledge, nightshift, workspace, and platform modules. The largest removal is the entire orphaned
agentfox/fix/module (10 source files, ~2,200 lines) whose CLI entry point had been deleted but whose backing code was never cleaned up.Closes #690
Changes
packages/agentfox/agentfox/fix/tests/unit/fix/+test_fix_analyzer_readonly.pytests/unit/platform/test_pr_creation.pyengine/engine.pyAssessmentManagerstubgraph/file_impacts.py_BARE_FILE_REregexknowledge/formatting.pyformat_verdict_parts/sort_verdictsengine/review_persistence.pyconverge_multi_instance_skepticworkspace/git.py+__init__.pymerge_fast_forward+ re-exportplatform/protocol.py+github.pyPullRequestResult/create_pull_requestengine/session_lifecycle.pyself._instancescore/config.pyshallow_mergeengine/parallel.pyexecute_batchknowledge/db.py_setup_vss)agentspec/__init__.pyCampaignre-exportnightshift/app.pyafaudit.nightshift_summaryimportVerification
Auto-generated by
af-fix.