fix(session): record per-tool errors via PostToolUseFailure SDK hook (fixes #672)#674
Open
mickume wants to merge 1 commit into
Open
fix(session): record per-tool errors via PostToolUseFailure SDK hook (fixes #672)#674mickume wants to merge 1 commit into
mickume wants to merge 1 commit into
Conversation
…ixes #672) The tool_errors table was always empty because record_tool_error() only fired on session-level is_error, not on individual tool failures. The Claude Agent SDK handles tool results internally — per-tool errors never surfaced through the streaming interface. Registered a PostToolUseFailure hook that fires for each tool invocation failure, calling record_tool_error() and record_tool_error_trace() with the tool name and error message from the SDK hook input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
tool_errorstable was always empty becauserecord_tool_error()only fired on session-levelis_error, not on individual tool failures. The Claude Agent SDK'sPostToolUseFailurehook fires for each tool invocation failure, providingtool_nameanderror— exactly what's needed.Closes #672
Changes
packages/agentfox/agentfox/session/backends/claude.pyPostToolUseFailurehook +_build_tool_error_hook()packages/agentfox/agentfox/session/session.py_on_tool_errorclosure, passed astool_error_callback**kwargsfor forward compatibilityVerification
Auto-generated by
af-fix.