Skip to content

iter57 cluster-067: 工作流步骤参数强类型化 direct-mapping(#941)#949

Merged
loning merged 1 commit into
auto-refact-devfrom
refactor/iter57-cluster-067-workflow-step-params
May 24, 2026
Merged

iter57 cluster-067: 工作流步骤参数强类型化 direct-mapping(#941)#949
loning merged 1 commit into
auto-refact-devfrom
refactor/iter57-cluster-067-workflow-step-params

Conversation

@loning
Copy link
Copy Markdown
Contributor

@loning loning commented May 24, 2026

摘要

iter57 cluster-067(severity:high)— Workflow step parameters 强类型化(direct-mapping baseline)

  • Old:Workflow 步骤参数把控制语义塞进字符串袋(StepRequestEvent.parameters map<string, string>),违反 "核心语义强类型"
  • New:typed WorkflowStepParameters proto + StepRequestEvent.step_parameters=8 direct-mapping(field 5 reserved);YAML 表层 parameters: 保持不动;projection 侧 derived adapters 仅覆盖 compile-required surface

违反:CLAUDE.md「核心语义强类型」「字段命名 Metadata 决策树」「核心语义强类型,只有插件/第三方/跨边界透传需求明确时才保留 bag」

Phase 9 共识链路(7-round + 2 reflector)

Round Verdict
r1 escalate:philosophy:docs-canon
reflector r1 retry-fix:不 touch canon
r2 converge:choose direct vs registry + field 5
r3 converge:narrow direct-mapping vs registry
r4 converge:reserve field 5 settled
r5 escalate:stalled(2/3 direct vs 1/3 registry)
reflector r2 retry-fix:direct-mapping baseline + schema-registry deferred
r6 converge:proto field name + first PR boundary
r7 META_JUDGE_DONE:consensus:minimal:use StepRequestEvent.step_parameters=8 with direct mapping and bounded projection source adaptation

Scope

  • 新 proto WorkflowStepParameters typed message
  • StepRequestEvent field 8 step_parameters + field 5 reserved
  • runtime contract:Aevatar.Workflow.Core 直接 typed mapping
  • minimal projection adapter(compile-required only)
  • YAML 表层 + docs/canon 不动
  • existing behavior tests + 新 WorkflowAbstractionsProtoCoverageTests/WorkflowExecutionProjectionProjectorTests 覆盖

local PASS:architecture + test_stability + dotnet build(0 errors)

closes #941

🤖 Generated with Claude Code via codex-refactor-loop iter57

⟦AI:AUTO-LOOP⟧

将 StepRequestEvent 的运行时参数迁移到 WorkflowStepParameters step_parameters 字段,并保留直接映射的源码使用面。投影侧只增加最小参数源适配,YAML parameters 表层不变。

⟦AI:AUTO-LOOP⟧
@loning
Copy link
Copy Markdown
Contributor Author

loning commented May 24, 2026

📊 状态卡片 — reviewer 派出

维度
阶段 派出 codex(role=reviewer)
codex log review-pr949-omnibus-r1.log
工作目录 /Users/auric/aevatar
timeout 5400s(~90 min 上限)
上下文 omnibus r1(架构/测试/质量综合)
下一步自动会做 1. 三 reviewer 完成 verdict marker 2. controller 计算 consensus 3. unanimous → auto-merge / reject → fix r<N+1>
是否需要人介入 ❌ 否(自动推进)

🤖 controller status banner

⟦AI:AUTO-LOOP⟧

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.51%. Comparing base (f82a239) to head (088da8d).
⚠️ Report is 37 commits behind head on auto-refact-dev.

@@                 Coverage Diff                 @@
##           auto-refact-dev     #949      +/-   ##
===================================================
+ Coverage            82.83%   83.51%   +0.68%     
===================================================
  Files                  998      988      -10     
  Lines                63092    63614     +522     
  Branches              8161     8216      +55     
===================================================
+ Hits                 52261    53129     +868     
+ Misses                7304     6923     -381     
- Partials              3527     3562      +35     
Flag Coverage Δ
ci 83.51% <100.00%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Workflow.Abstractions/StepRequestEvent.Partial.cs 100.00% <100.00%> (ø)
...WorkflowExecutionArtifactMaterializationSupport.cs 81.01% <100.00%> (+0.04%) ⬆️
...rojectors/WorkflowStepParameterProjectionSource.cs 100.00% <100.00%> (ø)

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loning loning merged commit 1f5bf9d into auto-refact-dev May 24, 2026
12 checks passed
loning added a commit that referenced this pull request May 24, 2026
…958)

* iter57 cluster-073: Studio C# typed StepParameters AST(#954)

Phase 9 r4 consensus(4-round + reflector r1 救场;in-process AST 不必 proto):
- 新 C# typed StudioStepParameters + typed sub-types(in-process authoring AST)
- 替 Domain JsonNode bag
- YAML adapter 边界保留 JSON
- runtime export 走 #949 已 typed WorkflowStepParameters proto
- deferred:Studio proto 留作 future when crosses durable/distributed boundaries

closes #954
local PASS:architecture + test_stability + build

⟦AI:AUTO-LOOP⟧

* iter57 cluster-073 test-add r1: 补 StudioStepParameters typed AST 覆盖(codecov/patch 53.52%→target)

PR #958 codecov/patch fail = 53.52%(24 misses + 9 partials)。
补 narrow tests 覆盖 24 lines on StudioStepParameters typed paths。

local PASS:Studio.Tests StudioStepParameter filter + test_stability_guards

⟦AI:AUTO-LOOP⟧
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant