chore: sync contract copy to dspack v0.4 (PR-14a)#13
Merged
Conversation
M3 plan Phase 1, PR-14a — mechanical consumer sync after dspack#11: input/shadcn-ui.dspack.json pulled via check:sync --write (v0.4, contract 2.1.0). The v0.4 additions are contract metadata + rules, which the transformer ignores by design, so the ONLY derived change is the generated headers' version string — the json-render codegen goldens diff exactly one line each; catalog content byte-identical. Emitters consume governed CSRs, not rules; nothing else moves. 49 tests, check:sync, build, json-render gates (J2/J3) all green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR syncs the vendored shadcn/ui dspack contract copy to dspack v0.4 (contract version 2.1.0) to eliminate drift against the upstream dspack repository, and updates the derived json-render goldens accordingly.
Changes:
- Update
input/shadcn-ui.dspack.jsonto dspack"0.4"/ contract"2.1.0", including upstream v0.4 governance additions (component categories + categories registry + new rules). - Refresh generated json-render golden headers so they reflect dspack
"0.4".
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| input/shadcn-ui.dspack.json | Upstream contract sync to dspack v0.4 / version 2.1.0; includes new categories/rules metadata from source-of-truth. |
| golden/json-render/registry.tsx.golden | Regenerated header to reflect dspack "0.4" (no functional changes in the stub registry shown in diff). |
| golden/json-render/catalog.ts.golden | Regenerated header to reflect dspack "0.4" (catalog content unchanged in diff besides the header). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
M3 plan Phase 1, PR-14a — the mechanical contract-copy sync after dspack#11 (v0.4).
check:sync --writepulledinput/shadcn-ui.dspack.jsonto contract 2.1.0; this turns dspack-emit's drift check green again (planned Phase 1 sequence).The interesting non-event
The v0.4 additions (categories registry + membership metadata, two new rules) are governance-side: emitters consume governed CSRs, never rules, so the transformer ignores all of it by design. The only derived change is the generated-file headers'
dspack "0.3" → "0.4"string — the json-render codegen goldens (the standing hand-review artifact) diff exactly one line each, catalog content byte-identical. The protocol-neutrality seam holding under a spec revision is the review, in two lines.Acceptance
npx vitest run— 49/49node scripts/check-sync.mjs— in sync against merged dspack mainnpm run test:json-render— J2/J3 gates green over the governed corpusnpm run build— clean🤖 Generated with Claude Code