feat: v0.4 amendment sync — vendored schema, 2.2.0 copy, evaluator pin#16
Merged
Conversation
…n (amendment leg) The ds-mcp leg of the ADR-M3-1 amendment (dspack#13, dspack-gen#25, dspack-emit#14): - vendored dspack.v0.4.schema.json refreshed to the amended bytes (textScope + dependentRequired; loader would reject textScope contracts on the stale schema) - contract copy synced to 2.2.0 (check-sync --write) - dspack-gen pin 6c84531 -> f6514330 (the amended-evaluator main) - the v0.4 pin test now asserts BOTH sides of the amended semantics through validate-ui: nested label text is clean (liftable), no-text-anywhere violates AT the trigger 93 tests + check:sync green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs ds-mcp to the v0.4 ADR-M3-1 amendment by updating the vendored JSON Schema, updating the vendored shadcn/ui v0.4 contract copy, and pinning dspack-gen to a commit that implements the amended evaluator semantics used by validate-ui.
Changes:
- Refresh
dspack.v0.4.schema.jsonto supporttextScope(self/subtree) plusdependentRequiredenforcement forrequired-props. - Update the shadcn/ui v0.4 contract copy to 2.2.0 and adjust the trigger-label governance rule to use
textScope: subtree. - Bump the pinned
@aestheticfunction/dspack-gengit SHA and extend the pin test to assert both “nested label is clean” and “no text anywhere fails at the trigger”.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/generation-tools.test.ts | Expands the validate-ui pin test to cover both sides of the amended required-props/textScope behavior. |
| src/schema/dspack.v0.4.schema.json | Adds textScope and dependentRequired for amended required-props schema validation. |
| package.json | Pins @aestheticfunction/dspack-gen to the amended evaluator commit. |
| package-lock.json | Updates the lockfile entry for the new dspack-gen commit. |
| examples/shadcn-ui-v04.dspack.json | Syncs the contract copy to 2.2.0 and updates the trigger-label rule to match the amendment semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The ds-mcp leg of the ADR-M3-1 amendment (dspack#13 · dspack-gen#25 · dspack-emit#14, all merged).
dspack.v0.4.schema.jsonrefreshed to the amended bytes (textScope+dependentRequired) — the loader would rejecttextScopecontracts on the stale schema.6c84531→f6514330(the amended-evaluator main).validate-ui: the 2026-07-03 signature shape (label nested in a badge) lints clean — the audited lift can project it — while no-text-anywhere violates at the trigger. The MCP tool now gives agents the amended semantics verbatim.Acceptance
npm test— 93/93 ·check-sync— all three copies in sync · CI is the gate.Next: the amendment-effect rerun (dspack-gen), running now.
🤖 Generated with Claude Code