Add remaining interesting bits for the SupportDesk HTTP API - #1929
Open
redstrate wants to merge 1 commit into
Open
Add remaining interesting bits for the SupportDesk HTTP API#1929redstrate wants to merge 1 commit into
redstrate wants to merge 1 commit into
Conversation
This will enable us to finally introspect the data for these requests! The most important bit was figuring out the stages and then making up a sensible delegate to hook into.
redstrate
commented
Aug 20, 2026
| /// <param name="dataLength">Length of the data buffer.</param> | ||
| /// <returns>The new HTTPRequest handle if it could be successfully created.</returns> | ||
| [VirtualFunction(4)] | ||
| public partial HttpRequest* MakeRequest(byte* url, byte* verb, byte* data, ulong dataLength); |
Contributor
Author
There was a problem hiding this comment.
I'm a little unsure about this API, because I'm not really sure what kind of string it is. On the plugin side, I can do Marshal.PtrToStringAnsi on this and get a valid string, so is it a CStringPointer? And then data is technically always a valid string too as far as I've seen, maybe I should do the same there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable us to finally introspect the data for these requests! The most important bit was figuring out the stages and then making up a sensible delegate to hook into.