Skip to content

fix: NavigationTree updates from testing - #10507

Open
snowystinger wants to merge 5 commits into
mainfrom
tree-nav-updates
Open

fix: NavigationTree updates from testing#10507
snowystinger wants to merge 5 commits into
mainfrom
tree-nav-updates

Conversation

@snowystinger

@snowystinger snowystinger commented Aug 25, 2026

Copy link
Copy Markdown
Member

Closes

Fixes from testing:

  • add starter storybook stories
  • add test for opening a non-href item that contains children
    • as a result of this, add property to context so that we can open on a link click and not rely on the the events which were stopped by the link that wasn't doing anything
  • move inline alert down to content
  • fix page auto scroll, page will no longer scroll down to the last example in the navigation tree docs page
  • make indicator smaller and no longer change selected one's colour on hover
  • change structure of starters to support adding buttons as children
  • fix webkit tap highlight

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the RAC label Aug 25, 2026
@rspbot

rspbot commented Aug 25, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 25, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 25, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 25, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (10)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/90448eba71124d35dce34b1c96465269407912f1/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/90448eba71124d35dce34b1c96465269407912f1/

@snowystinger
snowystinger marked this pull request as ready for review August 25, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants