fix: TokenField bugs - #10505
Open
devongovett wants to merge 5 commits into
Open
Conversation
devongovett
commented
Aug 24, 2026
| // its leading newline. Windows/Linux have no such shortcut: Ctrl+Backspace deletes the | ||
| // previous word ("world"), leaving the newline behind. | ||
| await waitForFieldText(getValue, isMacPlatform() ? 'hello' : 'hello\n'); | ||
| await waitForFieldText(getValue, 'hello\n'); |
Member
Author
There was a problem hiding this comment.
The IME fix #10422 broke this test on macOS. getTargetRanges includes a range when deleting to the beginning of the line that does not include the newline. Now that we are using that range instead of computing it ourselves, we get this difference.
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:setInteractionModality-setInteractionModality {
- modality: Modality
- returnVal: undefined
-}/react-aria-components:Modality-Modality {
- M: undefined
-} |
devongovett
marked this pull request as ready for review
August 24, 2026 20:13
LFDanLu
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box-decoration-break: cloneonClickhandler to tokens to select them when tapping with a touch screen reader.::selectionstyle to the token wrapper element using an injected stylesheet in RAC. Not sure if too opinionated, but also not sure why you'd want the default text selection when there is a custom selection style for tokens.