Skip to content

fix: Add --preferPlainHtml flag#2724

Open
swetabar wants to merge 1 commit into
adobe:mainfrom
swetabar:feat/prefer-plain-html
Open

fix: Add --preferPlainHtml flag#2724
swetabar wants to merge 1 commit into
adobe:mainfrom
swetabar:feat/prefer-plain-html

Conversation

@swetabar
Copy link
Copy Markdown

Add an opt-in --prefer-plain-html flag to aem up so .plain.html wins over .html sibling in --html-folder mode

Related Issues

https://github.com/Adobe-AEM-Foundation/aem-experience-catalyst/issues/1129

Comment thread src/server/HelixServer.js
// Try .plain.html
const plainHtmlFile = path.resolve(
// Try second extension
const secondFile = path.resolve(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than first/second have you considered an approach where an arbitrary length array of options is allowed? (if it helps simplify, otherwise probably not worth it)

@tripodsan
Copy link
Copy Markdown
Contributor

@davidnuescheler @kptdobe why is there a fallback to .plain.html at all?

@kptdobe
Copy link
Copy Markdown
Contributor

kptdobe commented May 13, 2026

Because you approved it - see #2631
@karlpauls introduced it, not super clear why.

@alexcarol
Copy link
Copy Markdown
Contributor

alexcarol commented May 13, 2026

In experience modernization agent we're generating .plain.html that are both used to show the user a "preview" of their content and then get uploaded to DA once the user is satisfied. Considering the new "aem content" approach it might make sense to look at going "back" to generating .md files, but for now we're still using ".plain.html", so it makes sense to have a way to have a way to "prioritize them".

@tripodsan
Copy link
Copy Markdown
Contributor

Because you approved it - see #2631 @karlpauls introduced it, not super clear why.

@karlpauls I'm not sure anymore why we need to serve the .plain.html files on non plain requests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants