Fix stereo signal processing within audiofilters.Filter#11025
Open
relic-se wants to merge 1 commit into
Open
Conversation
tannewt
requested changes
May 26, 2026
Member
tannewt
left a comment
There was a problem hiding this comment.
Are there any tests you could expand to test this?
Author
|
@tannewt Using the example code provided in #11024 (comment), here are the results of that test:
The stereo waveform graph above adheres to the following settings: Here's the same test but with varying filter frequencies:
I can come up with a more objective test if desired. In my subjective opinion, it sounds significantly better in stereo and mono is unaffected. |
Author
|
@tannewt The code I have provided does work, but I think there is room for optimization if you or someone else is willing to dive into it in a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Previously, left and right channels of stereo audio data were being treated as mono when processing through
audiofilters.Filter. This update properly handles stereo data within this class by separating channel sample data intofilter_statesandfilter_buffer.For interest, @gamblor21 @todbot
Fixes #11024