Skip to content

Fix typo in deeplake (#3149)#3158

Closed
bglglzd wants to merge 1 commit into
activeloopai:mainfrom
bglglzd:bugfix/3149-20260712-193227
Closed

Fix typo in deeplake (#3149)#3158
bglglzd wants to merge 1 commit into
activeloopai:mainfrom
bglglzd:bugfix/3149-20260712-193227

Conversation

@bglglzd

@bglglzd bglglzd commented Jul 12, 2026

Copy link
Copy Markdown

Small scoped patch based on the reported behavior.

Related to #3149.

Summary by CodeRabbit

  • Documentation

    • Updated contribution guidance with an additional test option.
    • Improved API documentation formatting instructions.
    • Refined README formatting across feature descriptions, tool comparisons, navigation, and licensing information.
    • Added follow-up guidance for security reports that have not received a response within 72 hours.
  • Chores

    • Maintained build configuration and packaging metadata for improved consistency.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 51522349-614d-42ec-8473-c5527b7757d4

📥 Commits

Reviewing files that changed from the base of the PR and between f432041 and c75260f.

📒 Files selected for processing (6)
  • CONTRIBUTING.md
  • README.md
  • SECURITY.md
  • cpp/3rd_party/json/CMakeLists.txt
  • cpp/CMakeLists.txt
  • cpp/vcpkg-configuration.json

📝 Walkthrough

Walkthrough

Documentation guidance, README formatting, security reporting instructions, and CMake/vcpkg configuration were updated. The changes are primarily whitespace, formatting, and small documentation additions, with one JSON library target adjustment.

Changes

Documentation updates

Layer / File(s) Summary
Contributor guidance and API documentation
CONTRIBUTING.md
Adds the --gcs test option and adjusts API documentation code-block spacing.
README formatting
README.md
Reformats navigation, feature, comparison, and license-disclaimer sections.
Security reporting guidance
SECURITY.md
Adds a 72-hour follow-up instruction for unanswered reports.

Native build configuration

Layer / File(s) Summary
CMake target and probe configuration
cpp/3rd_party/json/CMakeLists.txt, cpp/CMakeLists.txt
Configures the json library target and normalizes spacing around optional native capability checks.
Vcpkg configuration formatting
cpp/vcpkg-configuration.json
Changes the file’s ending formatting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A bunny found whitespace tucked in a row,
Added GCS where test commands go.
CMake built JSON with a hop and a cheer,
Security guidance grew clearer this year.
README lines danced in a neat little flow.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions a typo fix, but the changes are mostly docs, formatting, and config tweaks rather than a typo correction. Rename the PR to reflect the actual scope, or adjust the diff so it באמת fixes the typo described in the title.
Description check ⚠️ Warning The description is far too sparse and omits the required Impact, Description, Things to be aware of, Things to worry about, and Additional Context sections. Expand the PR body to fill the template sections, summarize the change, link issue #3149, and note any risks or context.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bglglzd bglglzd closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants