fix: honor project-range op permissions in UserCanOpDB - #660
Open
LordofAvernus wants to merge 1 commit into
Open
fix: honor project-range op permissions in UserCanOpDB#660LordofAvernus wants to merge 1 commit into
LordofAvernus wants to merge 1 commit into
Conversation
Treat OpRangeType=project as full project DB hit, merge member project permission slots, and include pending unmasking assignees in export pending_for_me.
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/953
描述你的变更
UserCanOpDB/GetCanOpDBUsers认OpRangeType=project为项目全量数据源命中ListUsersOpPermissionInProject合并成员项目权限槽;允许纯 project 范围角色挂载pending_for_meOR 关联 pending 原文指派确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docMade with Cursor
Description
更新成员角色权限校验逻辑
强化项目范围权限处理
扩展SQL查询合并项目权限槽
添加新单元测试覆盖项目范围权限场景
File Walkthrough
member.go
更新成员权限校验逻辑internal/dms/biz/member.go
op_permission_verify.go
改进DB权限判断逻辑internal/dms/biz/op_permission_verify.go
op_permission_verify.go
优化项目权限SQL查询internal/dms/storage/op_permission_verify.go
workflow.go
优化工作流过滤SQL逻辑internal/dms/storage/workflow.go
op_permission_verify_test.go
扩展权限测试用例覆盖internal/dms/biz/op_permission_verify_test.go