refactor(data_export_workflow): streamline current step assignee logic#598
Open
winfredLIN wants to merge 1 commit intomainfrom
Open
refactor(data_export_workflow): streamline current step assignee logic#598winfredLIN wants to merge 1 commit intomainfrom
winfredLIN wants to merge 1 commit intomainfrom
Conversation
- Updated the logic for determining current step assignees in the ListDataExportWorkflow and GetGlobalWorkflowsList methods to use a new helper function, improving readability and maintainability. - Adjusted SQL query to handle current step assignee user ID list based on workflow status, ensuring correct assignment visibility based on workflow state.
Member
|
没有在复审记录中找到这个MR => https://github.com/actiontech/sqle-ee/pull/2733?open_in_browser=true |
1 similar comment
Member
|
没有在复审记录中找到这个MR => https://github.com/actiontech/sqle-ee/pull/2733?open_in_browser=true |
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2682?open_in_browser=true
link https://github.com/actiontech/sqle-ee/pull/2733?open_in_browser=true
link https://github.com/actiontech/sqle-ee/pull/2735
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
重构获取当前步骤待处理人逻辑
新增辅助函数封装状态判断
更新SQL中待处理人查询表达式
Diagram Walkthrough
File Walkthrough
data_export_workflow.go
重构服务层待处理人逻辑internal/dms/service/data_export_workflow.go
workflow.go
调整SQL查询中待处理人逻辑internal/dms/storage/workflow.go