simplify condition for ABSL_INTERNAL_STD_FILESYSTEM_PATH_HASH_AVAILABLE#2066
Open
h-vetinari wants to merge 1 commit into
Open
simplify condition for ABSL_INTERNAL_STD_FILESYSTEM_PATH_HASH_AVAILABLE#2066h-vetinari wants to merge 1 commit into
h-vetinari wants to merge 1 commit into
Conversation
derekmauro
requested changes
Jun 1, 2026
| return H::combine_contiguous(std::move(hash_state), str.data(), str.size()); | ||
| } | ||
|
|
||
| #if defined(__cpp_lib_filesystem) && __cpp_lib_filesystem >= 201703L && \ |
Member
There was a problem hiding this comment.
Of all the PRs I've accepted, I don't think there is any I regret accepting more than adding hashing for std::filesystem::path. I must have wasted an entire week on workarounds for platforms that do not have a file system. I think it is fine to remove ENVIRONMENT stuff, but please restore the __cpp_lib_filesystem guards. I don't feel like researching it, but I think there are platforms that do not define this because they do not have a file system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conditions for
ABSL_INTERNAL_STD_FILESYSTEM_PATH_HASH_AVAILABLEare basically always true, since abseil now requires C++17 (and all compilers have implemented__cpp_lib_filesystemfor a long time), plus the macOS lower bound has long moved past the versions being considered here.It could be deleted entirely depending on what's the status resp. support for XTENSA. I've left it in for now because I don't know the details there.