Add full license text rule for the Jakub Jirak proprietary license - #5293
Open
MGpromax wants to merge 1 commit into
Open
Add full license text rule for the Jakub Jirak proprietary license#5293MGpromax wants to merge 1 commit into
MGpromax wants to merge 1 commit into
Conversation
The text was only detected through two partial fragment matches with scores of 90 and 10.87. Add the complete text as a new proprietary-license rule so it is detected in full with a single 100-score match. Reference: aboutcode-org#5290 Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
AyanSinhaMahapatra
requested changes
Aug 27, 2026
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks @MGpromax see comments for changes. Also rebase with develop
| license_expression: proprietary-license | ||
| is_license_text: yes | ||
| notes: proprietary license text of Jakub Jirak as seen in https://github.com/JirakJ/lincense | ||
| reported in scancode-toolkit issue 5290 |
Member
There was a problem hiding this comment.
as long as the reference is present in the commit this need not be there on the notes.
| - support@jakubjirak.com | ||
| --- | ||
|
|
||
| Copyright (c) 2025 Jakub Jirák. All rights reserved. This software and its source code are proprietary and confidential. Unauthorized copying, modification, distribution, or reverse engineering of this software, via any medium, is strictly prohibited. You are granted a non-exclusive, non-transferable license to use this software only in accordance with the terms agreed upon at the time of purchase or download. For licensing or support inquiries, contact: support@jakubjirak.com No newline at end of file |
Member
There was a problem hiding this comment.
can you remove the copyright part? Not required in the rule
| --- | ||
| license_expression: proprietary-license | ||
| is_license_text: yes | ||
| notes: proprietary license text of Jakub Jirak as seen in https://github.com/JirakJ/lincense |
Member
There was a problem hiding this comment.
please add a high, 95 minimum_coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5290
The license text at the URL in the issue was detected as
proprietary-licensebut only through two partial fragment matches (scores 90 and 10.87). This adds the complete text as a newproprietary-licensefull-text rule (proprietary-license_1064.RULE, with the ignorables generated by the validation test regen tooling), so the text now detects in full:Validation:
scancode-reindex-licensesclean; the self-detection and ignorables validation tests for the new rule pass.Tasks