Add new license bsd-3-clause-cryptogams for the CRYPTOGAMS license - #5288
Add new license bsd-3-clause-cryptogams for the CRYPTOGAMS license#5288MGpromax wants to merge 3 commits into
Conversation
Add new license bsd-3-clause-cryptogams, requested in issue aboutcode-org#5253. The license text now detects as bsd-3-clause-cryptogams with score 100; it previously matched a spurious combination of unrelated licenses. Reference: aboutcode-org#5253 Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
The CRYPTOGAMS fossology test files now detect as the new dedicated bsd-3-clause-cryptogams license instead of the bsd-new OR gpl-1.0-plus approximation. Adding the new license text to the index also perturbs two unrelated detections (manual-bsdstyle gains a bsd-source-code match; the bilingual MulanPSL-1.0.t1 file now matches three mulanpsl-1.0-en regions instead of one mulanpsl-1.0) - regenerated with SCANCODE_REGEN_TEST_FIXTURES and flagged in the PR for review. Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
|
CI update: the
|
CI on Linux shows both files detect exactly as before this license was added (single bzip2-libbzip-2010 and single mulanpsl-1.0 matches); the changed detections in the previous commit were an artifact of the local environment's text decoding, not an effect of the new license. Keep only the two CRYPTOGAMS expectation updates. Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
|
Correction to my previous comment: the CI logs show that on Linux the |
|
@MGpromax as a general rule going ahead do not add PRs for issues which are already assigned to one of the maintainers: #5253 this means there is more consideration required from maintainers. No need to close the PRs, some could be useful. Please assign @hesa as reviewers in new license PRs. @hesa maybe some of these at https://github.com/aboutcode-org/scancode-toolkit/pulls?q=is%3Aopen+is%3Apr+author%3AMGpromax+%22new+license%22 can be useful? Please take a look at your convenience. |
Fixes #5253
Adds
bsd-3-clause-cryptogamsfor the CRYPTOGAMS license (the BSD-3-Clause variant used by Andy Polyakov's CRYPTOGAMS cryptographic assembly modules, with an alternative clause allowing distribution under the GPL instead), using the name suggested in the issue. Text from the LICENSE file of https://github.com/dot-asm/cryptogams; SPDX has no identifier for it (checked the current license list), sospdx_license_key: LicenseRef-scancode-bsd-3-clause-cryptogams.category: Permissive, with the GPL-alternative clause recorded innotes.Detection before this change: the text matched
bsd-new OR gpl-1.0-plus, which approximates the semantics but loses the CRYPTOGAMS identity that tools like ORT need to track these files precisely. It now detects asbsd-3-clause-cryptogamswith score 100.Validation (same for all six license additions from this batch):
scancode-reindex-licensesruns clean--test-suite=validate tests/licensedcode/test_detection_validate.py), with ignorables generated by the test regen tooling rather than by handpytest tests/licensedcode/test_license_models.pypasses locallyTasks