Skip to content

Add new license bsd-3-clause-cryptogams for the CRYPTOGAMS license - #5288

Open
MGpromax wants to merge 3 commits into
aboutcode-org:developfrom
MGpromax:add-bsd-3-clause-cryptogams-license
Open

Add new license bsd-3-clause-cryptogams for the CRYPTOGAMS license#5288
MGpromax wants to merge 3 commits into
aboutcode-org:developfrom
MGpromax:add-bsd-3-clause-cryptogams-license

Conversation

@MGpromax

Copy link
Copy Markdown
Contributor

Fixes #5253

Adds bsd-3-clause-cryptogams for the CRYPTOGAMS license (the BSD-3-Clause variant used by Andy Polyakov's CRYPTOGAMS cryptographic assembly modules, with an alternative clause allowing distribution under the GPL instead), using the name suggested in the issue. Text from the LICENSE file of https://github.com/dot-asm/cryptogams; SPDX has no identifier for it (checked the current license list), so spdx_license_key: LicenseRef-scancode-bsd-3-clause-cryptogams.

category: Permissive, with the GPL-alternative clause recorded in notes.

Detection before this change: the text matched bsd-new OR gpl-1.0-plus, which approximates the semantics but loses the CRYPTOGAMS identity that tools like ORT need to track these files precisely. It now detects as bsd-3-clause-cryptogams with score 100.

Validation (same for all six license additions from this batch):

  • scancode-reindex-licenses runs clean
  • self-detection and ignorables validation tests pass (--test-suite=validate tests/licensedcode/test_detection_validate.py), with ignorables generated by the test regen tooling rather than by hand
  • pytest tests/licensedcode/test_license_models.py passes locally

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable) -- not applicable
  • Updated CHANGELOG.rst (if applicable) -- not applicable

Add new license bsd-3-clause-cryptogams, requested in issue aboutcode-org#5253. The license text
now detects as bsd-3-clause-cryptogams with score 100; it previously matched a spurious
combination of unrelated licenses.

Reference: aboutcode-org#5253
Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
The CRYPTOGAMS fossology test files now detect as the new dedicated
bsd-3-clause-cryptogams license instead of the bsd-new OR gpl-1.0-plus
approximation. Adding the new license text to the index also perturbs
two unrelated detections (manual-bsdstyle gains a bsd-source-code
match; the bilingual MulanPSL-1.0.t1 file now matches three
mulanpsl-1.0-en regions instead of one mulanpsl-1.0) - regenerated
with SCANCODE_REGEN_TEST_FIXTURES and flagged in the PR for review.

Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
@MGpromax

Copy link
Copy Markdown
Contributor Author

CI update: the license_datadriven_ext failures were expectation files predating the new license. Pushed a regen with an honest breakdown:

  • fossology-licenses/cryptogams.txt and fossology-tests/Dual-license/CRYPTOGAMS.txt now detect as bsd-3-clause-cryptogams instead of the bsd-new OR gpl-1.0-plus approximation -- the intended improvement.
  • Two unrelated detections shift as a side effect of the new text entering the index, and I want to flag them rather than bury them in the regen: fossology-tests/BSD/manual-bsdstyle gains an additional bsd-source-code expression, and glc/MulanPSL-1.0.t1 (the bilingual text) goes from a single mulanpsl-1.0 match to three mulanpsl-1.0-en region matches, which looks like a small quality regression for that one file. If you'd rather I dig into the MulanPSL interaction before this lands, happy to do that.

CI on Linux shows both files detect exactly as before this license
was added (single bzip2-libbzip-2010 and single mulanpsl-1.0
matches); the changed detections in the previous commit were an
artifact of the local environment's text decoding, not an effect of
the new license. Keep only the two CRYPTOGAMS expectation updates.

Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
@MGpromax

Copy link
Copy Markdown
Contributor Author

Correction to my previous comment: the CI logs show that on Linux the manual-bsdstyle and MulanPSL-1.0.t1 detections are unchanged by this license addition (single bzip2-libbzip-2010 and single mulanpsl-1.0 matches, same as before). The "perturbation" I reported was an artifact of my local environment's text decoding (both files contain non-ASCII text: fi-ligatures and the bilingual Chinese text; I run the system libmagic fallback), and my fixture regen wrongly encoded those local results. I reverted the two files to their original expectations and kept only the two CRYPTOGAMS expectation updates, which are the intended effect of the PR. Sorry for the noise -- CI should be fully green now.

@AyanSinhaMahapatra

Copy link
Copy Markdown
Member

@MGpromax as a general rule going ahead do not add PRs for issues which are already assigned to one of the maintainers: #5253 this means there is more consideration required from maintainers. No need to close the PRs, some could be useful. Please assign @hesa as reviewers in new license PRs.

@hesa maybe some of these at https://github.com/aboutcode-org/scancode-toolkit/pulls?q=is%3Aopen+is%3Apr+author%3AMGpromax+%22new+license%22 can be useful? Please take a look at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New license request: BSD-3-Clause Cryptogams

2 participants