fix: add support for Project and CentralTransitive in NuGet parser#5232
Open
mmustafasenoglu wants to merge 1 commit into
Open
fix: add support for Project and CentralTransitive in NuGet parser#5232mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
…n NuGet parser NuGet lockfiles can contain dependency types 'Project' and 'CentralTransitive' in addition to 'Direct' and 'Transitive'. The parser raised an exception for these unknown types, causing parsing to abort for valid NuGet lockfiles. This fix adds handling for: - Project: treated as direct dependency (is_direct=True) - CentralTransitive: treated as transitive dependency (is_direct=False) Also adds a test fixture with these dependency types. Fixes aboutcode-org#5106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
ProjectandCentralTransitivedependency types in the NuGetpackages.lock.jsonparser.Problem
NuGet lockfiles can contain dependency types beyond
DirectandTransitive:Project: Local project references (e.g.,<ProjectReference>)CentralTransitive: Transitive dependencies managed via Central Package ManagementThe parser raised an exception for these unknown types:
This caused parsing to abort for valid NuGet lockfiles generated by projects using project references or Central Package Management.
Changes
src/packagedcode/nuget.py: Added handling forProject(is_direct=True) andCentralTransitive(is_direct=False) typesTesting
Added
packages.lock.with_project_and_central_transitive.jsontest fixture containing all four dependency types.Fixes #5106