Skip to content

Exclude auto generated src folder from eslint#33

Merged
Peter080202 merged 2 commits into
mainfrom
exclude-generated-src-folder-from-eslint
Jul 1, 2026
Merged

Exclude auto generated src folder from eslint#33
Peter080202 merged 2 commits into
mainfrom
exclude-generated-src-folder-from-eslint

Conversation

@Peter080202

@Peter080202 Peter080202 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Configured ESLint to skip linting the auto-generated src folder which contains generated icon components.
Since all the files in src are auto generated in generator.js I think this approach is the best solution but I am open for other suggestions/solutions 🙂.

Why?

Otherwise we timeout when releasing a new package see https://github.com/aboutbits/react-material-icons/actions/runs/28516232653.

Testing

Now all actions pass.

@Peter080202 Peter080202 self-assigned this Jul 1, 2026
@Peter080202 Peter080202 requested a review from lukasvice July 1, 2026 12:26
@lukasvice

Copy link
Copy Markdown
Member

Hmm, this is the main directory for the project. If it is not linted, only some configuration files are linted. Could we lint-fix these files directly after generation and ignore them otherwise? Or should we only ignore them in GitHub Actions? What do you think?

@Peter080202

Copy link
Copy Markdown
Contributor Author

Hmm, this is the main directory for the project. If it is not linted, only some configuration files are linted. Could we lint-fix these files directly after generation and ignore them otherwise? Or should we only ignore them in GitHub Actions? What do you think?

I am not sure actually. There are 20.000+ files in src therefore linting will always time out due to different reasons if run in Github Actions...
As you suggested, we are now doing a lint fixing directly after generation (see 876576a) and exclude the src folder when doing a lint in Github Actions or locally.

@lukasvice lukasvice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good compromise

@Peter080202 Peter080202 merged commit 7bf224f into main Jul 1, 2026
6 checks passed
@Peter080202 Peter080202 deleted the exclude-generated-src-folder-from-eslint branch July 1, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants