Leave the overview app off the page in web/ - #57
Merged
Conversation
Z2UI5_CL_SMPS_APP_000 is this same catalogue rendered inside a system, and as a card on https://abap2ui5.github.io/samples-stack/ it answered the page's own question with a contradiction: "Needs nothing beyond abap2UI5", on a page whose premise is that every sample here needs something from the system. It also took a technology chip of its own that filtered ten groups down to one entry, itself. So the cut happens in generate-web-index.mjs, before the page ever sees it: the class and its Overview group are dropped, and the page shows 31 samples in 9 groups where SAMPLES.md and catalogue.json keep showing 32 - their reader is inside the repository already, and there the overview app is a sample somebody starts. The page names it in "How to run one" instead, which is where a way of browsing belongs rather than a thing to browse for. Consequences: - scan-samples.mjs exports OVERVIEW_CLASS, so the two generators behind the page name the class from one place. - generate-screenshots.mjs photographs what the page draws a card for and therefore skips it too - a picture no card loads is a render per deploy for nothing. Measured again: 18 of 31 app views render, the same 13 skips. - web/stack.js loses every `DATA.overviewApp` special case: every package it draws now has a branch and a README, so the package line, the Branch link and the package card are unconditional again, and apps.json no longer carries the field. Verified with a headless render of the page against a freshly generated apps.json: 31 cards, nine chips, no APP_000, every card with its three links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Z2UI5_CL_SMPS_APP_000is this same catalogue rendered inside a system, and as a card on https://abap2ui5.github.io/samples-stack/ it answered the page's own question with a contradiction: "Needs nothing beyond abap2UI5", on a page whose premise is that every sample here needs something from the system. It also took a technology chip of its own that filtered ten groups down to one entry — itself.The cut happens in
generate-web-index.mjs, before the page ever sees the data: the class and its Overview group are dropped, so the page shows 31 samples in 9 groups whereSAMPLES.mdandcatalogue.jsonkeep showing 32. Their reader is inside the repository already, and there the overview app is a sample somebody starts. The page names it in How to run one instead, which is where a way of browsing belongs rather than a thing to browse for.What changed
scripts/generate-web-index.mjsapps.jsonno longer carriesoverviewAppscripts/lib/scan-samples.mjsOVERVIEW_CLASS, so the two generators behind the page name the class from one placescripts/generate-screenshots.mjsweb/stack.jsDATA.overviewAppspecial case: every package it draws now has a branch and a README, so the package line, the Branch ↗ link and the package card are unconditional againAGENTS.md§8,web/README.md,web/index.htmlSAMPLES.md,catalogue.jsonand the overview app itself are untouched.Verification
npm run checkgreen end to end —check-webnow reports 31 app(s) in 9 group(s).apps.json: 31 cards, nine chips, noAPP_000anywhere, every card with its three links, no console errors.Generated by Claude Code