fix: Don't generate empty metadata change events in VertexTaskStore#962
Draft
gaborfeher wants to merge 1 commit intoa2aproject:mainfrom
Draft
fix: Don't generate empty metadata change events in VertexTaskStore#962gaborfeher wants to merge 1 commit intoa2aproject:mainfrom
gaborfeher wants to merge 1 commit intoa2aproject:mainfrom
Conversation
gaborfeher
force-pushed
the
gaborfeher-md2
branch
from
9362870 to
54a8d70
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the VertexTaskStore to prevent the generation of metadata change events when metadata transitions between empty values, such as {} and None. It also includes a new test case to verify that these transitions do not increment the event sequence number. A review comment suggests moving the explanatory comment above the conditional logic for better clarity and correcting a minor grammatical error.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/contrib/tasks/vertex_task_store.py | 91.60% | 95.42% | 🟢 +3.82% |
| Total | 91.72% | 91.82% | 🟢 +0.10% |
Generated by coverage-comment.yml
gaborfeher
force-pushed
the
gaborfeher-md2
branch
from
54a8d70 to
e1651fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #751