fix: JsonRPC errors should have a 'data' field not a 'details' field.#790
Merged
kabir merged 1 commit intoa2aproject:mainfrom Apr 10, 2026
Merged
fix: JsonRPC errors should have a 'data' field not a 'details' field.#790kabir merged 1 commit intoa2aproject:mainfrom
kabir merged 1 commit intoa2aproject:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the JSON-RPC error response serialization in JSONRPCUtils.java to use the data field instead of details, aligning with JSON-RPC 2.0 standards. Feedback indicates that the deserialization logic in processError remains unchanged and still expects the details field, which could cause issues when processing responses. It is recommended to update the parsing logic and include a test case to ensure consistency.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.