Skip to content

[Chore] Remove unused nightly extension path - #1454

Draft
zoomote[bot] wants to merge 3 commits into
mainfrom
feature/remove-nightly-app-1d274ppsdnpwg
Draft

[Chore] Remove unused nightly extension path#1454
zoomote[bot] wants to merge 3 commits into
mainfrom
feature/remove-nightly-app-1d274ppsdnpwg

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

Closes: N/A - maintainer-requested cleanup from Discord.

Description

Remove the unused standalone zoo-code-nightly extension and its build, packaging, installation, webview, and runtime-specific wiring.

The supported release paths remain unchanged: pull requests continue to produce test VSIX artifacts, and merges to main continue to publish the normal zoo-code extension through the pre-release channel. Removing the separate variant also removes its now-unused manifest transformation utilities, tests, and dependencies. The build package keeps Vitest as a dev dependency because the shared TypeScript configuration references vitest/globals.

Test Procedure

  1. Run pnpm test.
  2. Run pnpm check-types.
  3. Run pnpm --filter @roo-code/build build.
  4. Run pnpm --filter @roo-code/vscode-webview build.
  5. Confirm the standard bundle, vsix, and install:vsix scripts remain available and no tracked code or configuration references zoo-code-nightly or apps/vscode-nightly.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the requested nightly-path removal.
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: Existing tests and build checks cover the remaining supported paths.
  • Visual Snapshot (UI changes only): Not applicable; this change removes non-visual build tooling.
  • Documentation Impact: No user-facing documentation updates are required.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Visual Snapshots

Not applicable; there is no user-facing UI change.

Videos (interaction / animation only)

Not applicable.

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Additional Notes

The active .github/workflows/nightly-publish.yml workflow is intentionally preserved because it publishes the supported normal extension as a pre-release; it does not use the removed standalone nightly app. The root mkdirp dependency was also removed after the nightly packager became its final root-level consumer.

Get in Touch

Mention @roomote in the PR or use the linked task thread above.

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Review process

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

  1. Required CI checks pass.
  2. The workflow starts CodeRabbit automatically.
  3. For eligible human-authored PRs, CodeRabbit reviews and approves the latest commit.
  4. A human maintainer reviews and approves after CodeRabbit.

Current step: Mark the PR ready to start CodeRabbit after required CI passes.

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e59cfae7-025a-4183-b27b-e439dc510d14

📥 Commits

Reviewing files that changed from the base of the PR and between 1979a8a and acd522d.

📒 Files selected for processing (1)
  • webview-ui/src/vite-plugins/sourcemapPlugin.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (4)
Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths. Verify promises and errors are handled, existing helpers are reused, and new code introduces no `any`, unjustified dou...

⚙️ CodeRabbit configuration file

Files:

  • webview-ui/src/vite-plugins/sourcemapPlugin.ts
Check React state and effect dependencies, cleanup, accessibility, i18n, and light/dark theme behavior. New markup should use Tailwind; add VS Code CSS variables to `src/index.css` before Tailwind use. Use Vitest for behavior and Playwright...

⚙️ CodeRabbit configuration file

Files:

  • webview-ui/src/vite-plugins/sourcemapPlugin.ts
Act as an adversarial second-opinion reviewer. Verify PR claims against implementation, contracts, and tests. Trace changed inputs through normal, boundary, error, cancellation, retry, and default paths and their consumers. Seek plausible c...

⚙️ CodeRabbit configuration file

Files:

  • webview-ui/src/vite-plugins/sourcemapPlugin.ts
Fix lint violations in new TypeScript code instead of suppressing them.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • webview-ui/src/vite-plugins/sourcemapPlugin.ts
🔇 Additional comments (1)
webview-ui/src/vite-plugins/sourcemapPlugin.ts (1)

21-22: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Changes
    • Removed support for the nightly VS Code extension build and installation workflow.
    • The extension installer now installs the standard release package without nightly-specific options, metadata, or labeling.
    • Version selection now follows standard release compatibility rules.
    • Webview builds consistently use the standard output location and configuration, improving build consistency for the regular extension package.

Walkthrough

The PR removes the VS Code nightly package and build pipeline. It standardizes webview output and VSIX installation on the regular package. It also removes nightly-specific version selection, configuration tests, build helpers, schemas, and exports.

Changes

Nightly build removal

Layer / File(s) Summary
Remove nightly build wiring
apps/vscode-nightly/*, package.json, webview-ui/*
Nightly scripts, webview output paths, and nightly Vite mode handling are removed. The nightly build directory is no longer ignored.
Clean build package surface
packages/build/*
Obsolete package generation exports, contribution schemas, and the package test script are removed.
Standardize VSIX installation
scripts/install-vsix.js
The installer always reads ./src/package.json and uses a generic installer heading. The --nightly path is removed.
Remove nightly runtime handling
src/api/providers/fetchers/*, src/core/tools/*, src/eslint-suppressions.json
Nightly version selection and configuration namespace coverage are removed. The related comment and ESLint suppression count are updated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to acd52

This cleanup removes an unused nightly extension path while preserving the supported release workflows, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: edelauna

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the scope, preserved release paths, test procedure, checklist status, and documentation impact. However, it does not link an approved GitHub Issue, and the required Issue Link… Add the approved GitHub Issue number to the Related GitHub Issue section and mark the Issue Linked checklist item as complete. If no issue exists, create or link an approved issue before merging.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: removal of the unused nightly extension path.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Regression Evidence ✅ Passed No custom-check failure is introduced. The diff removes the unsupported nightly path and its dedicated helper implementation and tests. The standard version-selection tests retain exact-match, highest…
Trust And Persistence Invariants ✅ Passed PASS. The exact PR diff removes the standalone nightly build and packaging paths and removes nightly-only version selection. The installer change reads the same stable src/package.json; its existing…
Full details: Description check

Explanation

The description explains the scope, preserved release paths, test procedure, checklist status, and documentation impact. However, it does not link an approved GitHub Issue, and the required Issue Linked checklist item remains unchecked.

Full details: Regression Evidence

Explanation

No custom-check failure is introduced. The diff removes the unsupported nightly path and its dedicated helper implementation and tests. The standard version-selection tests retain exact-match, highest-eligible, no-match, and empty-input coverage. NewTaskTool retains coverage for the zoo-code namespace and enabled/disabled todo-setting paths. The normal bundle, VSIX, and nightly-publish workflows remain on the standard extension path. The webview changes affect build output configuration only, not visible UI, so no Playwright component snapshot is required. The remaining source changes are comments, constant-path cleanup, or removal of deleted functionality; no changed supported behavior lacks focused coverage under the stated policy.

Full details: Trust And Persistence Invariants

Explanation

PASS. The exact PR diff removes the standalone nightly build and packaging paths and removes nightly-only version selection. The installer change reads the same stable src/package.json; its existing editor command execution is unchanged, so the PR does not introduce new unvalidated execution. The webview changes only redirect build artifacts and retain existing synchronous artifact writes. No changed path handles secrets or PII, bypasses approval or allowlist controls, loses persisted application state, or leaks lifecycle resources.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/remove-nightly-app-1d274ppsdnpwg

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

webview-ui/src/vite-plugins/sourcemapPlugin.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@edelauna

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants