[Chore] Remove unused nightly extension path - #1454
Conversation
Review processThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.
Current step: Mark the PR ready to start CodeRabbit after required CI passes. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (4)Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths. Verify promises and errors are handled, existing helpers are reused, and new code introduces no `any`, unjustified dou...⚙️ CodeRabbit configuration file Files:
Check React state and effect dependencies, cleanup, accessibility, i18n, and light/dark theme behavior. New markup should use Tailwind; add VS Code CSS variables to `src/index.css` before Tailwind use. Use Vitest for behavior and Playwright...⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer. Verify PR claims against implementation, contracts, and tests. Trace changed inputs through normal, boundary, error, cancellation, retry, and default paths and their consumers. Seek plausible c...⚙️ CodeRabbit configuration file Files:
Fix lint violations in new TypeScript code instead of suppressing them.📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR removes the VS Code nightly package and build pipeline. It standardizes webview output and VSIX installation on the regular package. It also removes nightly-specific version selection, configuration tests, build helpers, schemas, and exports. ChangesNightly build removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This cleanup removes an unused nightly extension path while preserving the supported release workflows, and no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the scope, preserved release paths, test procedure, checklist status, and documentation impact. However, it does not link an approved GitHub Issue, and the required Issue Linked checklist item remains unchecked. Full details: Regression EvidenceExplanation No custom-check failure is introduced. The diff removes the unsupported nightly path and its dedicated helper implementation and tests. The standard version-selection tests retain exact-match, highest-eligible, no-match, and empty-input coverage. NewTaskTool retains coverage for the Full details: Trust And Persistence InvariantsExplanation PASS. The exact PR diff removes the standalone nightly build and packaging paths and removes nightly-only version selection. The installer change reads the same stable
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
webview-ui/src/vite-plugins/sourcemapPlugin.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
Related GitHub Issue
Closes: N/A - maintainer-requested cleanup from Discord.
Description
Remove the unused standalone
zoo-code-nightlyextension and its build, packaging, installation, webview, and runtime-specific wiring.The supported release paths remain unchanged: pull requests continue to produce test VSIX artifacts, and merges to
maincontinue to publish the normalzoo-codeextension through the pre-release channel. Removing the separate variant also removes its now-unused manifest transformation utilities, tests, and dependencies. The build package keeps Vitest as a dev dependency because the shared TypeScript configuration referencesvitest/globals.Test Procedure
pnpm test.pnpm check-types.pnpm --filter @roo-code/build build.pnpm --filter @roo-code/vscode-webview build.bundle,vsix, andinstall:vsixscripts remain available and no tracked code or configuration referenceszoo-code-nightlyorapps/vscode-nightly.Pre-Submission Checklist
Visual Snapshots
Not applicable; there is no user-facing UI change.
Videos (interaction / animation only)
Not applicable.
Documentation Updates
Additional Notes
The active
.github/workflows/nightly-publish.ymlworkflow is intentionally preserved because it publishes the supported normal extension as a pre-release; it does not use the removed standalone nightly app. The rootmkdirpdependency was also removed after the nightly packager became its final root-level consumer.Get in Touch
Mention
@roomotein the PR or use the linked task thread above.