UN-3636 [FIX] Stop re-running cross-tier deps in every tier leg#2192
UN-3636 [FIX] Stop re-running cross-tier deps in every tier leg#2192chandrasekharan-zipstack wants to merge 1 commit into
Conversation
`--tier X` expanded each selected group's `depends_on` transitively, with no tier bound. `integration-workflow-execution` and `e2e-smoke` both declare `depends_on: [unit-sdk1, unit-workers]`, so those two unit groups ran again in the integration leg and a third time in the e2e leg. Tiers run as separate CI legs and the unit leg already covers them, so dep expansion is now bounded to the requested tier. Explicitly named groups are never dropped, and intra-tier deps (e2e-smoke -> e2e-login) still expand and order as before. Unrun deps do not weaken gating: `blocked_by` intersects with groups that failed in the same run. Measured on the last main run: ~88s of unit-workers and ~48s of unit-sdk1 re-executed per run. On the cloud CI runner the same duplication costs ~350s. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnLaN45ShBbcCXWZkqCThz
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



What
Bound the rig's
depends_onexpansion to the requested tier when--tieris passed.Why
integration-workflow-executionande2e-smokeboth declaredepends_on: [unit-sdk1, unit-workers]. Because--tierexpanded deps transitively with no tier bound, those two unit groups ran three times per CI run — once in the unit leg, again in the integration leg, again in the e2e leg.Measured on run
29891886572(main):unit-sdk1unit-workers≈136s of duplicate execution per run. On the cloud CI runner (
custom-k8s-runner, ~2 xdist workers) the same duplication costs ~350s.Changes
tests/rig/selection.py: with--tier, drop dep-expanded groups outside that tier. Explicitly named groups are never dropped.tests/rig/tests/test_selection.py: +3 tests — cross-tier dep not pulled in, explicit request survives the filter, expansion unchanged without a tier filter.Safety
e2e-smoke→e2e-login).blocked_byintersects with groups that failed in the same run, so a dep that wasn't run simply doesn't gate — and its own tier leg gates it.tests.rig validateOK — 18 groups, 16 critical paths. Full rig suite: 74 passed, 1 skipped.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnLaN45ShBbcCXWZkqCThz