Zombie api gadget#5784
Open
Stiofan-K wants to merge 1 commit into
Open
Conversation
groundwork for splitting off some the zombies into a gadget to be used by nanoplague
Contributor
Author
|
I'm a bit on the fence on some things, specifically handling the zombies arrays and such. I could unify/port/standerdise the countdown to revive aswell I suppose, though then it would not be possible to differentiate between zombie or nanoplague zombies. |
Contributor
|
What does each of the gadgets do? The descriptions of each should be updated to make this clear, because api_ and unit_ don't mean a whole lot. |
Contributor
Author
|
aaaaaye. Ideally I want to put as much into the helper gadget to avoid duplication, but I'm unsure if I can put more there without it becoming inflexible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting off some the zombies code into a gadget to later be used by nanoplague