Skip to content

fix(shortcuts): reopen closed tab with Ctrl+Shift+T, works from edito… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sagarambilpure wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shortcuts): reopen closed tab with Ctrl+Shift+T, works from edito… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ Note++ ships with `electron-updater` wired to the GitHub releases provider — s
| `Ctrl+O` | Open file |
| `Ctrl+S` / `Ctrl+Shift+S` | Save / Save All |
| `Ctrl+W` | Close tab |
| `Ctrl+Alt+T` | Reopen last closed tab |
| `Ctrl+Shift+T` | Reopen last closed tab |
| `Ctrl+P` | Quick Open |
| `Ctrl+Shift+P` | Command Palette |
| `Ctrl+Shift+G` | Toggle Source Control |
Expand Down
22 changes: 13 additions & 9 deletions src/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,7 +1503,7 @@ require(['vs/editor/editor.main'], () => {
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyMod.Shift | monaco.KeyMod.Alt | monaco.KeyCode.PageDown,
() => editor.trigger('keyboard', 'cursorColumnSelectPageDown', null));

// Ctrl+Alt+T (reopen closed tab) and Ctrl± / Ctrl0 (zoom) are wired
// Ctrl+Shift+T (reopen closed tab) and Ctrl± / Ctrl0 (zoom) are wired
// as document-level shortcuts in setupGlobalShortcuts() so they fire
// from whiteboard/drawio/game tabs too — Monaco's addCommand only
// fires while the editor has focus.
Expand Down Expand Up @@ -2670,7 +2670,7 @@ function initTabDrag(e, tabId, tabEl) {
e.preventDefault();
}

// ── Reopen-closed-tab stack (Ctrl+Alt+T) ────────────────────────────────
// ── Reopen-closed-tab stack (Ctrl+Shift+T) ──────────────────────────────
// LIFO of snapshots taken at the moment a tab is confirmed to close
// (after the "Save?" prompt, before splice). Reopen restores editor,
// whiteboard, and drawio tabs — never compare views (they're transient)
Expand Down Expand Up @@ -9475,21 +9475,25 @@ function setupAiPrefsPage() {
// from double-firing.
function setupGlobalShortcuts() {
document.addEventListener('keydown', (e) => {
// Skip when the user is typing in a form field — don't want to steal
// Ctrl+- inside a numeric input, for example.
const t = e.target;
if (t && (t.tagName === 'INPUT' || t.tagName === 'TEXTAREA' || t.isContentEditable)) return;

if (!e.ctrlKey && !e.metaKey) return;
const k = e.key;

// Ctrl+Alt+T → reopen the most recently closed tab.
if (e.altKey && !e.shiftKey && (k === 't' || k === 'T')) {
// Reopen the most recently closed tab — Ctrl+Shift+T (matches browsers /
// VS Code). Handled *before* the text-field guard below so it fires even
// while the Monaco editor (a hidden <textarea>) or any input has focus —
// reopening a closed note should work no matter where the caret is, just
// like in a browser.
if (e.shiftKey && !e.altKey && (k === 't' || k === 'T')) {
e.preventDefault(); e.stopPropagation();
reopenClosedTab();
return;
}

// Skip the remaining shortcuts when the user is typing in a form field —
// don't want to steal Ctrl+- inside a numeric input, for example.
const t = e.target;
if (t && (t.tagName === 'INPUT' || t.tagName === 'TEXTAREA' || t.isContentEditable)) return;

// Zoom in — Ctrl+= / Ctrl++ / Ctrl+NumpadAdd
if (!e.altKey && (k === '=' || k === '+' || e.code === 'NumpadAdd')) {
e.preventDefault(); e.stopPropagation();
Expand Down