Build: portability fixes for non-Linux/non-MSVC builds#46
Open
matteius wants to merge 1 commit intoXilinx:masterfrom
Open
Build: portability fixes for non-Linux/non-MSVC builds#46matteius wants to merge 1 commit intoXilinx:masterfrom
matteius wants to merge 1 commit intoXilinx:masterfrom
Conversation
- cdo-alloc.c, cdo-npi.c: drop <malloc.h> include. malloc/free are already available through <stdlib.h> on POSIX, and <malloc.h> is glibc-specific (absent on macOS / BSD). - main.cpp: drop the OpenSSL `applink.c` include that was guarded by _WIN32. applink.c is for MSVC link compatibility and is not present in modern OpenSSL distributions; the include breaks Windows builds against OpenSSL 3.x without providing any value on MinGW or recent MSVC + vcpkg builds. Surface: clean cross-platform compile of the bootgen sources that mlir-aie consumes via its submodule pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small portability fixes that let bootgen compile on macOS and against modern OpenSSL on Windows:
cdo-alloc.c,cdo-npi.c: drop#include <malloc.h>.malloc/freeare already available via<stdlib.h>on POSIX, and<malloc.h>is glibc-specific (absent on macOS / BSD).main.cpp: drop the#include "openssl/ms/applink.c"that was guarded by_WIN32.applink.cis for legacy MSVC link compatibility and is not present in modern OpenSSL distributions; the include breaks Windows builds against OpenSSL 3.x without providing any value on MinGW or recent MSVC + vcpkg builds.Net diff: 3 files, 3 insertions(+), 3 deletions(-).
Context
We hit these while consuming bootgen as a submodule via mlir-aie's pinned tree on a non-Linux developer machine. Happy to split into three commits if preferred.
Test plan
<stdlib.h>already providesmalloc/free.applink.cno longer required.