Fix missing ASM hang line in --dump-aie-status#27
Closed
jyothees99 wants to merge 2 commits into
Closed
Conversation
The --dump-aie-status path called AIEStatus.get() without forwarding the resolved debug_map.json path, so debug_map_json defaulted to None and the ASM hang line (ASM_OPCODE/ASM_OPCODE_LINE/ASM_OPCODE_FILE) was never emitted. - Forward args.debug_map_json into get() in launch_debug, guarded by an os.path.exists check that warns and degrades when the map is missing. - Harden _get_uc_status to skip (with a warning) instead of raising when the debug_map_json path does not exist. Co-authored-by: Cursor <cursoragent@cursor.com>
Centralize debug_map.json resolution so the ASM hang line is emitted by every status entry point (--dump-aie-status, --exec "status()"/"uc_status()", and the interactive a/u commands), not just --dump-aie-status. - AIEStatus stores a default debug_map_json (from args) at construction; update() and get_uc_status() fall back to it when callers pass None. - ClientDebug forwards args.debug_map_json into the AIEStatus constructor. - Drop the now-redundant explicit pass/guard in the --dump-aie-status branch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --dump-aie-status path called AIEStatus.get() without forwarding the resolved debug_map.json path, so debug_map_json defaulted to None and the ASM hang line (ASM_OPCODE/ASM_OPCODE_LINE/ASM_OPCODE_FILE) was never emitted.