Fix functions reachable through static mut#42
Merged
Conversation
See also WebAssembly/tool-conventions#153 for example Global initializers refering to data symbols, i.e. their address, do not get relocations targeting them. We reconstruct these missing relocations and insert dependencies for them by matching on the global name/symbol name.
WorldSEnder
force-pushed
the
static-mut-fix
branch
from
032cd6f to
cbb2487
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exported data symbols are exposed as globals containing the address of that data symbol. There are currently no relocations emitted for the global initializers. Hence, the dependency graph didn't detect that these symbols would be reachable and that their initializer expression had to be relocated.
Fixes #38 here such an exposed data symbol is introduced in wasm-bindgen (__abort_handler and __instance_terminated).