Skip to content

Fix startup NullReferenceException on WorldBox 0.51.2 (resilient power-tab lookup) #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Skilvin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix startup NullReferenceException on WorldBox 0.51.2 (resilient power-tab lookup) #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion general/PowerButtonCreator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,23 @@ void toggleOption(string pPower)
public static PowersTab GetTab(string pId)
{
if (string.IsNullOrEmpty(pId)) return null;

// Fast path (valid up to 0.51.0): hard-coded UI hierarchy lookup.
Transform tabTransform = CanvasMain.instance.canvas_ui.transform.Find(
$"CanvasBottom/BottomElements/BottomElementsMover/CanvasScrollView/Scroll View/Viewport/Content/Power Tabs/{pId}");
if (tabTransform != null)
{
var found = tabTransform.GetComponent<PowersTab>();
if (found != null) return found;
}

// Fallback (0.51.1+): the hierarchy moved. Locate the tab by its object name.
foreach (var tab in Resources.FindObjectsOfTypeAll<PowersTab>())
{
if (tab != null && tab.name == pId) return tab;
}

return tabTransform == null ? null : tabTransform.GetComponent<PowersTab>();
return null;
}

/// <summary>
Expand Down
16 changes: 12 additions & 4 deletions general/ui/tab/WrappedPowersTab.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,23 @@ public WrappedPowersTab(PowersTab pPowersTab)
{
Tab = pPowersTab;

Modifiable = !PowerTabNames.GetNames().Contains(Tab.name);

ButtonGroups = new();
CustomRectGroups = new();

AddGroup("Default");

_inactive_lines = new();
_active_lines = new();

if (Tab == null)
{
// Tab not found (e.g. hierarchy changed in a newer WorldBox build):
// don't NRE, just leave this wrapper inert.
Modifiable = false;
return;
}

Modifiable = !PowerTabNames.GetNames().Contains(Tab.name);

AddGroup("Default");
}

internal void RecordLine(GameObject line)
Expand Down