Plugin Directory: Change pre block overflow to auto. - #769
Open
softglazee wants to merge 1 commit into
Open
Conversation
The pre elements in the plugin directory currently use overflow: scroll, which unconditionally reserves gutter space for both vertical and horizontal scrollbars. Because these blocks lack a height constraint, vertical overflow does not occur. Changing this to auto removes the empty vertical gutter and keeps horizontal scrolling only where content genuinely overflows. See https://meta.trac.wordpress.org/ticket/8264
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Changed
overflow: scroll;tooverflow: auto;inwordpress.org/public_html/wp-content/themes/pub/wporg-plugins-2024/client/components/_code.scss(line 6).Why
The
<pre>blocks currently useoverflow: scroll, which unconditionally reserves gutter space for both vertical and horizontal scrollbars regardless of content size. Because these blocks lack a height constraint, vertical overflow does not occur, resulting in an empty vertical gutter. Usingoverflow: autoreclaims the unused gutter space and preserves the horizontal scrollbar only where the content genuinely overflows.Measurements
I applied the style change in the browser to measure the effect on scrollbar dimensions (
vBarPxandhBarPx). Note that this was measured via browser CSS injection on the live site, not a local build.Before (
overflow: scroll)After (
overflow: autoinjected via console)How to test
Load a plugin page with a code block, e.g.,
https://wordpress.org/plugins/gigroute-events/Run this console script to measure scrollbar width/height (
vBarPx/hBarPx) and confirmoverflowX:Inject the style fix via the console:
Confirm
getComputedStyle(document.querySelector('pre')).overflowXreturnsauto.Re-run the script from step 2 and compare the gutter dimensions.
Trac ticket: https://meta.trac.wordpress.org/ticket/8264
Use of AI Tools
This PR and the associated measurements were prepared with the assistance of an AI tool to help structure the data and format the report syntax. All testing, validation, environment setup, and conclusions are my own.