Skip to content

Plugin Directory: Emit a PHP warning when a ZIP fails to build #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obenland wants to merge 2 commits into
base: trunk
Choose a base branch
from
+8 −0
Open

Plugin Directory: Emit a PHP warning when a ZIP fails to build #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd7da77
Plugin Directory: Emit a PHP warning when a ZIP fails to build.
obenland Aug 5, 2026
fffb8d1
Merge branch 'trunk' into zip-build-warning
obenland Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,11 @@ protected function rebuild_affected_zips( $plugin_slug, $stable_tag, $current_st
$stable_tag
);
} catch ( Exception $e ) {
$this->warnings['zip_build_failed'] = $e->getMessage();

// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Routed to the error log via E_USER_WARNING; raw is fine.
trigger_error( sprintf( '%s: ZIP build failed for %s: %s', $plugin_slug, implode( ', ', array_unique( $versions_to_build ) ), $e->getMessage() ), E_USER_WARNING );

return false;
}

Expand Down
3 changes: 3 additions & 0 deletions wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ public function build( $slug, $versions, $context = '', $stable_tag = '' ) {

} catch ( Exception $e ) {
// In event of error, skip this file this time.
// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Routed to the error log via E_USER_WARNING; raw is fine.
trigger_error( sprintf( 'ZIP build failed for %s %s: %s', $this->slug, $version, $e->getMessage() ), E_USER_WARNING );

$this->cleanup_plugin_tmp();

// Perform an SVN up to revert any changes made.
Expand Down
Loading