Skip to content

#63949: Keep SNI enabled when SSL verification is disabled - #13753

Open
ArkaPrabhaChowdhury wants to merge 1 commit into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-63949-wp-cron-sni
Open

ArkaPrabhaChowdhury wants to merge 1 commit into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-63949-wp-cron-sni

Conversation

@ArkaPrabhaChowdhury

@ArkaPrabhaChowdhury ArkaPrabhaChowdhury commented Sep 25, 2026 •

Copy link
Copy Markdown

The PHP streams (fsockopen) transport disables Server Name Indication (SNI) whenever verifyname is false. WP-Cron's loopback request defaults to sslverify => false, which WordPress maps to verifyname => false. On a virtual host that requires SNI, that combination can send the request to the default TLS host and produce an HTTP 421 response.

Keep SNI enabled when the PHP/OpenSSL runtime supports it. Certificate verification remains disabled as requested; SNI still supplies the URL hostname during the TLS handshake. This is the same change already accepted on the Requests develop branch: WordPress/Requests@213f7e7. It also addresses the mechanism described in https://core.trac.wordpress.org/ticket/50288.

A local TLS listener recorded the SNI sent by Requests with verify => false and verifyname => false:

Transport SNI before SNI with patch
cURL localhost unchanged
fsockopen absent localhost

Both transports received HTTP 200 from the local listener. This verifies the SNI behavior; the reporter's Apache environment and active transport are not available, so the reported 421 response has not been reproduced end to end.

Checks: PHPCBF, PHPCS, PHP syntax, and git diff --check passed. Core PHPUnit was not run locally because this worktree has no wp-tests-config.php.

Trac ticket: https://core.trac.wordpress.org/ticket/63949

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-6
Used for: Ticket investigation, implementation, local SNI probe, and validation. The change and evidence were reviewed before publication.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props arkaprabhachowdhury.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant