Toolbar: Restore the color scheme text color on top-level label hover. - #12968
Toolbar: Restore the color scheme text color on top-level label hover.#12968itzmekhokan wants to merge 1 commit into
Conversation
The default admin bar styles still qualify the `span.ab-label` hover selector with `:not(.mobile)`, while [63009] dropped that qualifier from the matching color scheme rule. The qualifier makes the default rule the more specific of the two, so the hardcoded `#72aee6` wins over the color scheme on every top level node that outputs a label, such as "+ New", the command palette, Comments, and Updates. Drop the qualifier so both rules match the same elements again and the color scheme wins on cascade order, as it does for the surrounding toolbar hover rules. Fixes #65848.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thank you for the PR. I apologize if I'm mistaken, but the PR description appears to be entirely AI-generated, which makes it quite verbose and difficult for a human to read. Please refer to the AI guidelines, take responsibility for AI-generated content, and revise the text to be more human-readable and easier for reviewers. |
@t-hamano I've already added the Use of AI Tools disclosure in the description. |
|
@itzmekhokan The problem isn't the use of AI, which you disclosed responsibly, as expected. It's the PR description itself, which is extremely verbose. It would be much appreciated if you could edit those down to only the relevant details, rather than keeping the entirety of the AI feedback. |
Understood. Thanks, I've updated the PR description. |
4 participants
Fixes admin bar top-level labels (+ New, Command Palette, Comments, Updates) using the hardcoded #72aee6 hover color instead of the active admin color scheme.
The issue was a specificity mismatch: admin-bar.css still had span.ab-label:hover:not(.mobile), while the color scheme rule no longer excludes .mobile since [63009]. Removing :not(.mobile) aligns both selectors, allowing the color scheme rule to win by cascade order as intended.
No new mobile behavior is introduced; this simply restores consistency between the default and color scheme styles.
Trac ticket: https://core.trac.wordpress.org/ticket/65848
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Ticket analysis and code implementation. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.