Skip to content

52220 - weekly posts fix for first week #12961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sawfly wants to merge 2 commits into
base: trunk
Choose a base branch
from
+16 −11
Draft

52220 - weekly posts fix for first week #12961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b35c61
Fixed a bug with not all posts being selected for the first week of t…
sawfly Aug 10, 2026
c437931
ticket mismatch changed
sawfly Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/wp-includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7171,6 +7171,11 @@ function send_nosniff_header() {

/**
* Returns a MySQL expression for selecting the week number based on the start_of_week option.
* @ticket 52220 - Former used MySQL::WEEK modes 0 and 1 changed to 2 and 3 respectively.
* Modes 0 and 1 return weeks numbers from 0 to 53, while modes 2 and 3 return week numbers from 1 to 53 which is corresponds to our documentation:
* https://github.com/WordPress/wordpress-develop/blob/de2572b1da20f0fe6f53eebd6b8bf10ae066dd2f/src/wp-includes/class-wp-query.php#L807
* Also, WP ignores GET parameter w=0 and didn't allow to select posts from the first week (w=0) of the year correctly with 0 and 1 used modes.
* Modes 2 and 3 fix this issue and allow to select posts from the first week of the year correctly.
*
* @ignore
* @since 3.0.0
Expand All @@ -7182,16 +7187,16 @@ function _wp_mysql_week( $column ) {
$start_of_week = (int) get_option( 'start_of_week' );
switch ( $start_of_week ) {
case 1:
return "WEEK( $column, 1 )";
return "WEEK( $column, 3 )";
case 2:
case 3:
case 4:
case 5:
case 6:
return "WEEK( DATE_SUB( $column, INTERVAL $start_of_week DAY ), 0 )";
return "WEEK( DATE_SUB( $column, INTERVAL $start_of_week DAY ), 2 )";
case 0:
default:
return "WEEK( $column, 0 )";
return "WEEK( $column, 2 )";
}
}

Expand Down
16 changes: 8 additions & 8 deletions tests/phpunit/tests/functions/wpMysqlWeek.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ static function ( $value ) use ( $start_of_week ) {
*/
public function data_wp_mysql_week() {
return array(
array( '1969-12-25', 0, 'WEEK( col_name, 0 )' ),
array( '1969-12-25', 1, 'WEEK( col_name, 1 )' ),
array( '1969-12-25', 2, 'WEEK( DATE_SUB( col_name, INTERVAL 2 DAY ), 0 )' ),
array( '1969-12-25', 3, 'WEEK( DATE_SUB( col_name, INTERVAL 3 DAY ), 0 )' ),
array( '1969-12-25', 4, 'WEEK( DATE_SUB( col_name, INTERVAL 4 DAY ), 0 )' ),
array( '1969-12-25', 5, 'WEEK( DATE_SUB( col_name, INTERVAL 5 DAY ), 0 )' ),
array( '1969-12-25', 6, 'WEEK( DATE_SUB( col_name, INTERVAL 6 DAY ), 0 )' ),
array( '1969-12-25', 9, 'WEEK( col_name, 0 )' ),
array( '1969-12-25', 0, 'WEEK( col_name, 2 )' ),
array( '1969-12-25', 1, 'WEEK( col_name, 3 )' ),
array( '1969-12-25', 2, 'WEEK( DATE_SUB( col_name, INTERVAL 2 DAY ), 2 )' ),
array( '1969-12-25', 3, 'WEEK( DATE_SUB( col_name, INTERVAL 3 DAY ), 2 )' ),
array( '1969-12-25', 4, 'WEEK( DATE_SUB( col_name, INTERVAL 4 DAY ), 2 )' ),
array( '1969-12-25', 5, 'WEEK( DATE_SUB( col_name, INTERVAL 5 DAY ), 2 )' ),
array( '1969-12-25', 6, 'WEEK( DATE_SUB( col_name, INTERVAL 6 DAY ), 2 )' ),
array( '1969-12-25', 9, 'WEEK( col_name, 2 )' ),
);
}
}
Loading