Skip to content

Query: Add unit test for redirect_guess_404_permalink() post_type array leak #12941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irozum wants to merge 1 commit into
base: trunk
Choose a base branch
from
+5 −0
Open

Query: Add unit test for redirect_guess_404_permalink() post_type array leak #12941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/phpunit/tests/canonical.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ public function data_redirect_guess_404_permalink_with_custom_statuses() {
*
* @ticket 43056
* @ticket 59795
* @ticket 44964
*
* @dataProvider data_redirect_guess_404_permalink_post_types
*/
Expand Down Expand Up @@ -413,6 +414,10 @@ public function data_redirect_guess_404_permalink_post_types() {
'original_url' => '/?name=private-cpt-po&post_type[]=wp_tests_private',
'expected' => '/?name=private-cpt-po&post_type[]=wp_tests_private',
),
'do not leak private post type mixed in with a public one' => array(
'original_url' => '/?name=private-cpt-po&post_type[]=page&post_type[]=wp_tests_private',
'expected' => '/?name=private-cpt-po&post_type[]=page&post_type[]=wp_tests_private',
),
);
}

Expand Down
Loading