Skip to content

Privacy: Show an accurate notice when saving the Privacy Policy page setting#12247

Open
MicahelE wants to merge 1 commit into
WordPress:trunkfrom
MicahelE:fix/59276-privacy-policy-notice
Open

Privacy: Show an accurate notice when saving the Privacy Policy page setting#12247
MicahelE wants to merge 1 commit into
WordPress:trunkfrom
MicahelE:fix/59276-privacy-policy-notice

Conversation

@MicahelE

Copy link
Copy Markdown

Summary

Fixes #59276.

On Settings → Privacy, saving the Privacy Policy page setting always displayed "Privacy Policy page updated successfully." — even when no page was selected. This is misleading both when clearing a previously set page and when saving with no page selected and none set before.

Reproduction

  1. Go to Settings → Privacy
  2. Leave the Change your Privacy Policy page dropdown on — Select —
  3. Click Use This Page
  4. Notice incorrectly reads "Privacy Policy page updated successfully."

The fix

options-privacy.php now reads the previous option value before saving and branches the notice accordingly, following the behavior outlined by reviewers on the ticket:

Scenario Notice Type
A page is selected "Privacy Policy page updated successfully." (unchanged) success
A previously set page is cleared "Privacy Policy page removed." success
No page before, none now "No Privacy Policy page is currently set." info

The existing "update your menus" variant for published pages is preserved.

Testing

Verified all three scenarios end-to-end on the local Docker environment (Settings → Privacy):

Action Resulting notice
Select a page → Use This Page Privacy Policy page updated successfully. (success)
Clear a previously set page Privacy Policy page removed. (success)
Save with no page selected/none set (the reported bug) No Privacy Policy page is currently set. (info)
  • PHP lint: clean
  • PHPCS (phpcs.xml.dist): clean

The logic lives in the options-privacy.php admin page script (consistent with how other options-*.php pages build their add_settings_error() messages), so no unit test is added, matching existing conventions for these page scripts.

Trac ticket: https://core.trac.wordpress.org/ticket/59276

…setting.

The Settings > Privacy screen always displayed "Privacy Policy page updated successfully." after saving, even when no page was selected. This was misleading when clearing a previously set page, or when saving with no page selected and none set before.

The notice now branches on the previous and new option values:
- A page is selected: "Privacy Policy page updated successfully." (unchanged).
- A previously set page is cleared: "Privacy Policy page removed."
- No page was set before and none is set now: "No Privacy Policy page is currently set." (info notice).

Fixes #59276.
@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props micahele.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant