Privacy: Show an accurate notice when saving the Privacy Policy page setting#12247
Privacy: Show an accurate notice when saving the Privacy Policy page setting#12247MicahelE wants to merge 1 commit into
Conversation
…setting. The Settings > Privacy screen always displayed "Privacy Policy page updated successfully." after saving, even when no page was selected. This was misleading when clearing a previously set page, or when saving with no page selected and none set before. The notice now branches on the previous and new option values: - A page is selected: "Privacy Policy page updated successfully." (unchanged). - A previously set page is cleared: "Privacy Policy page removed." - No page was set before and none is set now: "No Privacy Policy page is currently set." (info notice). Fixes #59276.
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
Fixes #59276.
On Settings → Privacy, saving the Privacy Policy page setting always displayed "Privacy Policy page updated successfully." — even when no page was selected. This is misleading both when clearing a previously set page and when saving with no page selected and none set before.
Reproduction
The fix
options-privacy.phpnow reads the previous option value before saving and branches the notice accordingly, following the behavior outlined by reviewers on the ticket:The existing "update your menus" variant for published pages is preserved.
Testing
Verified all three scenarios end-to-end on the local Docker environment (
Settings → Privacy):phpcs.xml.dist): cleanThe logic lives in the
options-privacy.phpadmin page script (consistent with how otheroptions-*.phppages build theiradd_settings_error()messages), so no unit test is added, matching existing conventions for these page scripts.Trac ticket: https://core.trac.wordpress.org/ticket/59276