Posts, Post Types: Show modified date for pending/draft posts in the list table Date column#12246
Conversation
…list table Date column. The Posts list table Date column labeled non-published posts as "Last Modified" but displayed the post_date instead of the modified date. For a pending or draft post with a future publication date, this resulted in a future date being shown under a "Last Modified" label, which is misleading. This displays the modified date and time (via get_the_modified_time() and get_post_timestamp( $post, 'modified' )) for statuses other than publish and future, so the date shown matches the "Last Modified" label. Published and scheduled posts continue to show the publication date. Adds unit tests covering pending+scheduled, published, and scheduled posts. Fixes #40860.
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
Fixes #40860.
The Posts list table Date column labels non-published posts as "Last Modified" but displays the
post_dateinstead of the modified date. For a pending or draft post with a future publication date, this results in a future date being shown under a "Last Modified" label — which is incorrect and confusing.Reproduction
Verified on the local Docker environment:
The fix
In
WP_Posts_List_Table::column_date(), for statuses other thanpublishandfuture, display the modified date/time (viaget_the_modified_time()andget_post_timestamp( $post, 'modified' )) so the date shown matches the "Last Modified" label. Published and scheduled posts continue to show the publication date as before.Testing
Adds unit tests to
Tests_Admin_wpPostsListTable:test_column_date_shows_modified_date_for_pending_scheduled_post— asserts the modified date (not the future publication date) is shown for a pending+scheduled post. Fails without the fix, passes with it.test_column_date_uses_publication_date_for_published_and_scheduled(data provider: published, scheduled) — asserts published/scheduled posts still show the publication date and correct label.This builds on the approach proposed in the earlier patch on the ticket, adding unit test coverage (the ticket previously had
has-test-infobut no automated tests).Trac ticket: https://core.trac.wordpress.org/ticket/40860