Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| <script id="tmpl-revisions-buttons" type="text/html"> | ||
| <div class="revisions-previous"> | ||
| <input class="button" type="button" value="<?php echo esc_attr_x( 'Previous', 'Button label for a previous revision' ); ?>" /> | ||
| <input class="button button-compact" type="button" value="<?php echo esc_attr_x( 'Previous', 'Button label for a previous revision' ); ?>" /> |
There was a problem hiding this comment.
Surprisingly, despite the addition of a new compact size in 7.0, the button-compact class is actually being used for the first time in this PR. I believe this class should be actively used going forward, rather than hardcoding min-height: 32px in places where a compact size is expected.
|
|
||
| .wp-core-ui .button, | ||
| .wp-core-ui .button.button-large, | ||
| .wp-core-ui .button.button-compact, |
There was a problem hiding this comment.
I believe this is just an oversight. All buttons should be 40px in size on the mobile layout.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: #65062
Use of AI Tools
None
Screenshots