Skip to content

Revisions: fix misplaced buttons#11549

Open
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:65062-revisions-ui-button
Open

Revisions: fix misplaced buttons#11549
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:65062-revisions-ui-button

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

Trac ticket: #65062

Use of AI Tools

None

Screenshots

Width This PR WordPress 6.9
1200px image image
700px image image
360px image image

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

<script id="tmpl-revisions-buttons" type="text/html">
<div class="revisions-previous">
<input class="button" type="button" value="<?php echo esc_attr_x( 'Previous', 'Button label for a previous revision' ); ?>" />
<input class="button button-compact" type="button" value="<?php echo esc_attr_x( 'Previous', 'Button label for a previous revision' ); ?>" />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, despite the addition of a new compact size in 7.0, the button-compact class is actually being used for the first time in this PR. I believe this class should be actively used going forward, rather than hardcoding min-height: 32px in places where a compact size is expected.


.wp-core-ui .button,
.wp-core-ui .button.button-large,
.wp-core-ui .button.button-compact,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is just an oversight. All buttons should be 40px in size on the mobile layout.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant